Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer guide - index patterns key concepts #96017

Merged
merged 13 commits into from
Aug 15, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 1, 2021

closes: #92125

Adds index patterns key concept content to the developer guide.

Also moved a bunch of index pattern content from the data plugin readme to a tutorial page. The tutorial page is a straight ahead iteration over simple API use cases. It could use another pass but I didn't want the added scope creep to this task.

This PR adds the sidebar nav items - https://github.com/elastic/elastic-docs-next/pull/266

@mattkime mattkime changed the title add index patterns key concepts Developer guide - index patterns key concepts Apr 1, 2021
@mattkime mattkime added the docs label Apr 1, 2021
@mattkime mattkime marked this pull request as ready for review August 11, 2021 20:20
@mattkime mattkime requested a review from a team as a code owner August 11, 2021 20:20
@mattkime mattkime added v7.15.0 v8.0.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServices labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 11, 2021
@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls add instructions on how to build and run this locally? (sorry, I don't know that from the top of my head)

- Remove a scripted field — `DELETE /api/index_patterns/index_pattern/{id}/scripted_field/{name}`
- Update a scripted field — `POST /api/index_patterns/index_pattern/{id}/scripted_field/{name}`

### Dat aview API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Dat aview API
### Data view API

await data.indexPatterns.delete(dataViewId);
```

### Data view HTTP API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should delete this completely? (also delete from plugin readme)

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally,
As mentioned before suggest removing REST API mentions. Or maybe link from here to user-facing docs https://www.elastic.co/guide/en/kibana/master/index-patterns-api.html



The data view API is made available via the data plugin (`data.indexPatterns`, soon to be renamed) and most commonly used with <DocLink id="kibDevTutorialDataSearchAndSessions" section="high-level-search" text="SearchSource" />
(`data.search.search`) to perform queries. SearchSource will apply existing filters and queries from the search bar UI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(`data.search.search`) to perform queries. SearchSource will apply existing filters and queries from the search bar UI.
(`data.search.search.searchSource`) to perform queries. SearchSource will apply existing filters and queries from the search bar UI.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 2e68ce1 into elastic:master Aug 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 15, 2021
* add index patterns key concepts

Co-authored-by: Matthew Kime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index Patterns - high level docs
4 participants