Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and unskip functional test #96004

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

jportner
Copy link
Contributor

Resolves #96001.

@jportner jportner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 31, 2021
@jportner jportner requested a review from spalger March 31, 2021 22:42
@jportner jportner requested a review from a team as a code owner March 31, 2021 22:42
@jportner jportner enabled auto-merge (squash) March 31, 2021 22:42
@jportner jportner added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 31, 2021
@spalger
Copy link
Contributor

spalger commented Mar 31, 2021

Thank you @jportner, I'll merge upstream once https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/2536/ is done and we can test this against the new snapshot

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jportner!

@sqren the deprecation notice for the apm_user role doesn't indicate what is replacing the apm_user role. Do we have any guidance to share with our users yet, or is that still being worked on?

@spalger
Copy link
Contributor

spalger commented Apr 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 5743919 into elastic:master Apr 1, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 1, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #96076

This backport PR will be merged automatically after passing CI.

@jportner jportner deleted the issue-96001-skipped-test branch April 1, 2021 21:03
kibanamachine added a commit that referenced this pull request Apr 2, 2021
@sorenlouv
Copy link
Member

@sqren the deprecation notice for the apm_user role doesn't indicate what is replacing the apm_user role. Do we have any guidance to share with our users yet, or is that still being worked on?

You are correct. Eventually we want to replace the apm_user role with the upcoming stack-wide roles. I think they are scheduled for 7.13.

@legrego
Copy link
Member

legrego commented Apr 6, 2021

You are correct. Eventually we want to replace the apm_user role with the upcoming stack-wide roles. I think they are scheduled for 7.13.

I don't think these roles serve the same purpose. The stack-wide roles will grant some level of access to essentially all features, whereas your apm_user role grants access to just APM.

What if a user just wants APM access, and doesn't want to grant access to the other features enabled by these stack-wide roles?

@sorenlouv
Copy link
Member

What if a user just wants APM access, and doesn't want to grant access to the other features enabled by these stack-wide roles?

Then they can create a custom role. We don't want to have built-in roles for this in the future.

@sorenlouv
Copy link
Member

sorenlouv commented Apr 6, 2021

Today it's quite cumbersome to create custom roles. The user has to hunt down all the permissions needed for a specific solution.
In the future I hope the security ui will help the user with this, so the user can simply select "APM" and it will auto-populate the needed indices etc. So essentially creating a custom role should be as easy as using a built-in role.

@legrego
Copy link
Member

legrego commented Apr 7, 2021

Today it's quite cumbersome to create custom roles. The user has to hunt down all the permissions needed for a specific solution.
In the future I hope the security ui will help the user with this, so the user can simply select "APM" and it will auto-populate the needed indices etc. So essentially creating a custom role should be as easy as using a built-in role.

I agree 100%, and I think we've captured this already within #80634.

There is a similar initiative planned [at some point in the future] to handle this in a more holistic way -- something that won't just change the Kibana UI, but would potentially change the way we think about these privileges from a stack-wide perspective.

@sorenlouv
Copy link
Member

There is a similar initiative planned [at some point in the future] to handle this in a more holistic way -- something that won't just change the Kibana UI, but would potentially change the way we think about these privileges from a stack-wide perspective.

Sounds exciting. Keep me posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing ES Promotion: security app users should show the default roles
5 participants