-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OBS]home page is showing incorrect value of APM throughput (tpm) #95991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Mar 31, 2021
x-pack/plugins/apm/public/services/rest/apm_observability_overview_fetchers.ts
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 31, 2021
x-pack/plugins/apm/server/lib/observability_overview/get_transaction_per_minute.ts
Outdated
Show resolved
Hide resolved
smith
approved these changes
Apr 2, 2021
x-pack/plugins/apm/server/lib/observability_overview/get_transaction_per_minute.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/observability_overview/get_transaction_per_minute.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
cauemarcondes
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Apr 5, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 5, 2021
…astic#95991) * fixing obs transaction per minute value * addressing PR comments * fixing unit test * addressing PR comments Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 5, 2021
…5991) (#96217) * fixing obs transaction per minute value * addressing PR comments * fixing unit test * addressing PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 6, 2021
…-nav * 'master' of github.com:elastic/kibana: (106 commits) [Lens] don't use eui variables for zindex (elastic#96117) Remove /src/legacy (elastic#95510) skip flaky suite (elastic#95899) [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247) fixes a skipped management x-pack test (elastic#96178) [App Search] API logs: Add log detail flyout (elastic#96162) [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191) Add Input Controls project configuration (elastic#96238) [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883) Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223) [App Search] Added Sample Response section to Result Settings (elastic#95971) [Maps] Safe-erase text-field (elastic#94873) [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098) [Maps] Enable all zoom levels for all users (elastic#96093) Use plugin version in its publicPath (elastic#95945) [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984) [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100) [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991) [Observability] Exploratory View initial skeleton (elastic#94426) [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190) ... # Conflicts: # x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
ogupte
added
the
apm:test-plan-done
Pull request that was successfully tested during the test plan
label
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:test-plan-7.13.0
apm:test-plan-done
Pull request that was successfully tested during the test plan
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Observability Landing
release_note:fix
Team:APM
All issues that need APM UI Team support
v7.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #95492
@alex-fedotyev @cyrille-leclerc
Keep in mind that by changing it, the result will be different when more than one service is available:
Before: 41.69 tpm
After: 58.4 tpm
It changed because before I was calculating the mean value of all transaction types, and now to keep the value consistent I have to select one transaction type (Request or Page Load or the first one in the bucket).