Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBS]home page is showing incorrect value of APM throughput (tpm) #95991

Merged
merged 6 commits into from
Apr 5, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #95492

Screen Shot 2021-03-31 at 15 02 50

Screen Shot 2021-03-31 at 15 02 59

Screen Shot 2021-03-31 at 15 06 45

Screen Shot 2021-03-31 at 15 06 52

@alex-fedotyev @cyrille-leclerc
Keep in mind that by changing it, the result will be different when more than one service is available:
Before: 41.69 tpm
Screen Shot 2021-03-31 at 15 35 49

After: 58.4 tpm
Screen Shot 2021-03-31 at 15 34 49

It changed because before I was calculating the mean value of all transaction types, and now to keep the value consistent I have to select one transaction type (Request or Page Load or the first one in the bucket).

@cauemarcondes cauemarcondes requested a review from a team as a code owner March 31, 2021 21:08
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from sorenlouv April 2, 2021 13:33
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB -143.0B
observability 326.9KB 327.1KB +179.0B
total +36.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 5, 2021
@cauemarcondes cauemarcondes merged commit 9cebff1 into elastic:master Apr 5, 2021
@cauemarcondes cauemarcondes deleted the obs-tpm-chart branch April 5, 2021 14:52
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 5, 2021
…astic#95991)

* fixing obs transaction per minute value

* addressing PR comments

* fixing unit test

* addressing PR comments

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #96217

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 5, 2021
…5991) (#96217)

* fixing obs transaction per minute value

* addressing PR comments

* fixing unit test

* addressing PR comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Cauê Marcondes <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 6, 2021
…-nav

* 'master' of github.com:elastic/kibana: (106 commits)
  [Lens] don't use eui variables for zindex (elastic#96117)
  Remove /src/legacy (elastic#95510)
  skip flaky suite (elastic#95899)
  [Dashboard] Fix Lens and TSVB chart tooltip positioning relative to global headers (elastic#94247)
  fixes a skipped management x-pack test (elastic#96178)
  [App Search] API logs: Add log detail flyout (elastic#96162)
  [tech-debt] Remove defunct opacity parameters from EUI shadow functions (elastic#96191)
  Add Input Controls project configuration (elastic#96238)
  [file upload] document file upload privileges and provide actionable UI when failures occur (elastic#95883)
  Revert "TS Incremental build exclude test files (elastic#95610)" (elastic#96223)
  [App Search] Added Sample Response section to Result Settings (elastic#95971)
  [Maps] Safe-erase text-field (elastic#94873)
  [RAC][Alert Triage][TGrid] Update the Alerts Table (TGrid) API to implement `renderCellValue` (elastic#96098)
  [Maps] Enable all zoom levels for all users (elastic#96093)
  Use plugin version in its publicPath (elastic#95945)
  [Enterprise Search] Expose core.chrome.setIsVisible for use in Workplace Search (elastic#95984)
  [Workplace Search] Add sub nav and fix rendering bugs in Personal dashboard (elastic#96100)
  [OBS]home page is showing incorrect value of APM throughput (tpm) (elastic#95991)
  [Observability] Exploratory View initial skeleton (elastic#94426)
  [KQL] Fixed styles of KQL textarea for the K8 theme (elastic#96190)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/restore_snapshot.helpers.ts
@ogupte ogupte self-assigned this May 24, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated - use backport:version if exact versions are needed Feature:Observability Landing release_note:fix Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Observability home page is showing incorrect value of APM throughput (tpm)
6 participants