Index patterns server - throw correct error on field caps 404 #95879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
mattkime
added
release_note:skip
|
First pass looks good overall. Maps telemetry works as expected without ugly log messages. Need to do a deeper dive, but any idea why the error message is coming through To replicate:
|
|
@aaronjcaldwell I resolved the |
kindsun
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
tsullivan
reviewed
Apr 13, 2021
| ) { | ||
| throw new IndexPatternMissingIndices(pattern); | ||
| } else { | ||
| throw err; |
There was a problem hiding this comment.
When this is thrown, does the error get caught and logged to the server logs somewhere?
Or should there be a logger.error(err) before the throw?
There was a problem hiding this comment.
It gets caught and logged to the server logs - https://github.com/elastic/kibana/pull/95879/files#diff-a4e9a6425b24a341a47560c879ec9eb04e76748d29376a9c1390962d1da65c10R74 - its defined in the server abstraction layer.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kindsun
approved these changes
Apr 13, 2021
|
@mattkime Is there any possibility these changes could be backported to |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 13, 2021
…c#95879) * throw correct error on field caps 404 and update tests
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Apr 13, 2021
…c#95879) * throw correct error on field caps 404 and update tests # Conflicts: # src/plugins/data/server/index_patterns/index_patterns_service.ts
mattkime
added a commit
that referenced
this pull request
Apr 13, 2021
#97034) * throw correct error on field caps 404 and update tests # Conflicts: # src/plugins/data/server/index_patterns/index_patterns_service.ts
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2021
#97033) * throw correct error on field caps 404 and update tests Co-authored-by: Matthew Kime <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 14, 2021
…ax_primary_shard_size * 'master' of github.com:elastic/kibana: (99 commits) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) Index patterns server - throw correct error on field caps 404 (elastic#95879) Use `EuiThemeProvider` in lists plugin tests and stories (elastic#96129) [npm] upgrade caniuse database (elastic#97002) chore(NA): moving @kbn/apm-utils into bazel (elastic#96227) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the server side field caps api call was throwing a generic error and was therefore not caught as expected. This PR fixes this and tests that relied on this incorrect error.
Also simplifies a small amount of map related index pattern code. Previously the field list was being loaded manually which wasn't necessary.
Note: better fixes could be made to the tests but the scripted field code is being deprecated anyway. The tests started failing because the API was correctly reporting errors on index patterns without backing indices.
Closes: #92947