-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli-dev-mode/optimizer] omit pageLoadAssetSizeLimit from cache #95826
Merged
spalger
merged 4 commits into
elastic:master
from
spalger:fix/cli-dev-mode/optimizer-limits
Mar 30, 2021
Merged
[cli-dev-mode/optimizer] omit pageLoadAssetSizeLimit from cache #95826
spalger
merged 4 commits into
elastic:master
from
spalger:fix/cli-dev-mode/optimizer-limits
Mar 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport --verbose logging
spalger
added
Team:Operations
Team label for Operations Team
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.13.0
labels
Mar 30, 2021
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Mar 30, 2021
mshustov
approved these changes
Mar 30, 2021
spalger
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Mar 30, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 30, 2021
…tic#95826) Co-authored-by: spalger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Mar 31, 2021
…) (#95856) Co-authored-by: spalger <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #95822 I noticed a bug in the
@kbn/optimizer
cache that I believe @weltenwort had noticed before but we hadn't tracked down, wherenode scripts/build_kibana_platform_plugins
would report that all bundles were cached but they would then be rebuilt when you runyarn start
. The problem comes from #93153, where the limitsPath became a parameter passed in via the config. This param isn't passed to the optimizer when it's run viayarn start
, and since limits have no bering on the output of the bundles that is fine. To fix this I've excluded thepageLoadAssetSizeLimit
from the cache key created for each Bundle which will allow two executions of the@kbn/optimizer
which only differ in--limits
config to share caches.To aid in debugging and testing this I also added support for passing the
--verbose
flag passed toyarn start
through to the@kbn/optimizer
to enable its verbose logging.