Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli-dev-mode/optimizer] omit pageLoadAssetSizeLimit from cache #95826

Merged
merged 4 commits into from
Mar 30, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 30, 2021

While working on #95822 I noticed a bug in the @kbn/optimizer cache that I believe @weltenwort had noticed before but we hadn't tracked down, where node scripts/build_kibana_platform_plugins would report that all bundles were cached but they would then be rebuilt when you run yarn start. The problem comes from #93153, where the limitsPath became a parameter passed in via the config. This param isn't passed to the optimizer when it's run via yarn start, and since limits have no bering on the output of the bundles that is fine. To fix this I've excluded the pageLoadAssetSizeLimit from the cache key created for each Bundle which will allow two executions of the @kbn/optimizer which only differ in --limits config to share caches.

To aid in debugging and testing this I also added support for passing the --verbose flag passed to yarn start through to the @kbn/optimizer to enable its verbose logging.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 30, 2021
@spalger spalger requested review from a team as code owners March 30, 2021 18:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger enabled auto-merge (squash) March 30, 2021 19:42
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 30, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 2010f4e into elastic:master Mar 30, 2021
@spalger spalger deleted the fix/cli-dev-mode/optimizer-limits branch March 30, 2021 22:08
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 30, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95856

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants