[Search] Unify search plugin step 1 #95811

Dosant · 2021-03-30T15:58:48Z

Summary

Partially addresses #92802

In this pr:

Remove the defaultStrategy override
Move async search strategy to data
Move EQL search strategy to data
Move rest of common/search/session data (Moving whole search/session is blocked by security and taskManager)

Still TODO In separate pr:

Unify search interceptor (Wait for caching PR to avoid merges)
Deprecate TimeoutErrorMode.UPGRADE (Wait for caching PR to avoid merges)
Split rollups out of async search strategy - (Will pick up next)
Move rest of search/session to data (blocked by security and taskManager)

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

# Conflicts: # src/plugins/data/server/search/search_service.ts

# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md # src/plugins/data/README.mdx # src/plugins/data/server/search/search_service.ts # x-pack/plugins/data_enhanced/config.ts # x-pack/plugins/data_enhanced/server/plugin.ts # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts

# Conflicts: # src/plugins/data/common/search/types.ts # src/plugins/data/server/server.api.md

# Conflicts: # x-pack/plugins/data_enhanced/config.ts # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.test.ts # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts

This reverts commit 1ea7325.

Dosant · 2021-04-13T13:13:23Z

src/plugins/data/config.ts

@@ -30,3 +30,62 @@ export const configSchema = schema.object({
 });

 export type ConfigSchema = TypeOf<typeof configSchema>;
+
+export const searchSessionsConfigSchema = schema.object({


Had to move the schema now to src/ because ese strategy uses defaultExpiration from it.
This schema is still registered by x-pack/ code

Dosant · 2021-04-13T13:14:28Z

src/plugins/data/public/search/search_interceptor.ts

@@ -183,6 +184,11 @@ export class SearchInterceptor {
    request: IKibanaSearchRequest,
    options: ISearchOptions = {}
  ): Observable<IKibanaSearchResponse> {
+    options = {
+      strategy: ES_SEARCH_STRATEGY,


search_interceptor will be simplified in follow-up pr. for now I had to specify non async search strategy here, otherwise it would hit async and won't handle partial results.

Dosant · 2021-04-13T13:15:21Z

src/plugins/data/server/search/session/types.ts

@@ -31,6 +32,7 @@ export interface IScopedSearchSessionsClient<T = unknown> {
  cancel: (sessionId: string) => Promise<{}>;
  delete: (sessionId: string) => Promise<{}>;
  extend: (sessionId: string, expires: Date) => Promise<SavedObjectsUpdateResponse<T>>;
+  getConfig: () => SearchSessionsConfigSchema | null;


SearchSession still leave in x-pack, but ese strategy needs defaultExpiration from its config

test/api_integration/apis/search/bsearch.ts

lizozom

Reviewed as draft, without testing.
Looks like a good first step

src/plugins/data/server/search/search_service.test.ts

src/plugins/data/server/search/strategies/eql_search/types.ts

# Conflicts: # src/plugins/data/common/search/types.ts # x-pack/plugins/data_enhanced/public/search/search_interceptor.ts

elasticmachine · 2021-04-19T16:25:16Z

Pinging @elastic/kibana-app-services (Team:AppServices)

lizozom

LGTM

XavierM

Security solution are approved, I make sure to test it locally ;)

patrykkopycinski

Asset management LGTM

lukasolson

Left a couple of minor nits, but code LGTM, and tested locally and things seem to be working great!

src/plugins/data/README.mdx

src/plugins/data/server/search/search_service.test.ts

kibanamachine · 2021-04-21T12:23:16Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`data`	562	567	+5
`dataEnhanced`	104	99	-5
total			-0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataEnhanced`	159.0KB	159.2KB	+232.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	790.1KB	792.9KB	+2.9KB
`dataEnhanced`	35.1KB	33.1KB	-2.1KB
total			+819.0B

Unknown metric groups

API count

id	before	after	diff
`data`	3454	3476	+22
`dataEnhanced`	52	16	-36
total			-14

API count missing comments

id	before	after	diff
`data`	2958	2979	+21
`dataEnhanced`	34	16	-18
total			+3

History

💛 Build #120576 was flaky 3d86270
💚 Build #119591 succeeded 2f0e451
💚 Build #119184 succeeded 759ebef
💔 Build #119141 failed 1ea7325
💔 Build #118742 failed ea7e3b0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Remove the defaultStrategy override Move async search strategy to data Move EQL search strategy to data Move rest of common/search/session data (Moving whole search/session is blocked by security and taskManager)

Dosant added 20 commits March 30, 2021 17:57

unify search wip

327789a

docs & types

2b0bad9

fix types

46592b7

fix types

375473a

Merge branch 'master' of github.com:elastic/kibana into unify-search-1

48c7ef2

# Conflicts: # src/plugins/data/server/search/search_service.ts

fix

c1bdfa8

fix ts

f342a11

fix lint

652bb74

wip

a8906a7

wip

ecf38e5

wip

6ada319

Merge branch 'master' of github.com:elastic/kibana into unify-search-1

0143ebb

Merge branch 'master' of github.com:elastic/kibana into unify-search-1

407250e

# Conflicts: # src/plugins/data/common/search/types.ts # src/plugins/data/server/server.api.md

wip - fixing tests

278246c

improve

11e438e

docs

ea7e3b0

wip

1ea7325

Revert "wip"

759ebef

This reverts commit 1ea7325.

Dosant commented Apr 13, 2021

View reviewed changes

Dosant requested review from lizozom and lukasolson April 13, 2021 14:43

Dosant added 2 commits April 14, 2021 14:38

Merge branch 'master' of github.com:elastic/kibana into unify-search-1

f774a25

improve tests

2f0e451

lizozom reviewed Apr 19, 2021

View reviewed changes

src/plugins/data/server/search/search_service.test.ts Outdated Show resolved Hide resolved

src/plugins/data/server/search/strategies/eql_search/types.ts Outdated Show resolved Hide resolved

Dosant added 2 commits April 19, 2021 15:54

Merge branch 'master' of github.com:elastic/kibana into unify-search-1

5db84d5

# Conflicts: # src/plugins/data/common/search/types.ts # x-pack/plugins/data_enhanced/public/search/search_interceptor.ts

fix wrong type

3d86270

Dosant added Feature:Search Querying infrastructure in Kibana refactoring labels Apr 19, 2021

Dosant added release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture v7.14.0 v8.0.0 Team:AppServices labels Apr 19, 2021

Dosant marked this pull request as ready for review April 19, 2021 16:25

Dosant requested review from a team as code owners April 19, 2021 16:25

Dosant requested a review from lizozom April 19, 2021 16:25

lizozom approved these changes Apr 19, 2021

View reviewed changes

XavierM approved these changes Apr 20, 2021

View reviewed changes

patrykkopycinski approved these changes Apr 20, 2021

View reviewed changes

lukasolson approved these changes Apr 20, 2021

View reviewed changes

src/plugins/data/README.mdx Outdated Show resolved Hide resolved

src/plugins/data/server/search/search_service.test.ts Outdated Show resolved Hide resolved

Dosant added 2 commits April 21, 2021 11:50

Merge branch 'master' of github.com:elastic/kibana into unify-search-1

2eb7e4d

review and readme improvements

42e52ed

Dosant mentioned this pull request Apr 21, 2021

[Search] Unify data.search plugin #92802

Closed

10 tasks

Dosant merged commit bd4f461 into elastic:master Apr 21, 2021

Dosant mentioned this pull request Apr 21, 2021

[7.x] [Search] Unify search plugin step 1 (#95811) #97807

Merged

This was referenced Apr 21, 2021

[Search] Unify search plugin step 2 — Search Interceptor #97845

Merged

[Search] Unify search plugin step 3 — Rollup search strategy #98122

Closed

Dosant mentioned this pull request Apr 29, 2021

Failing test: API Integration Tests.test/api_integration/apis/search/bsearch·ts - apis search bsearch post should return 200 a single response #98245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search] Unify search plugin step 1 #95811

[Search] Unify search plugin step 1 #95811

Dosant commented Mar 30, 2021 •

edited

Loading

Dosant Apr 13, 2021

Dosant Apr 13, 2021

Dosant Apr 13, 2021

lizozom left a comment

elasticmachine commented Apr 19, 2021

lizozom left a comment

XavierM left a comment

patrykkopycinski left a comment

lukasolson left a comment

kibanamachine commented Apr 21, 2021

API count

API count missing comments

[Search] Unify search plugin step 1 #95811

[Search] Unify search plugin step 1 #95811

Conversation

Dosant commented Mar 30, 2021 • edited Loading

Summary

Checklist

For maintainers

Dosant Apr 13, 2021

Choose a reason for hiding this comment

Dosant Apr 13, 2021

Choose a reason for hiding this comment

Dosant Apr 13, 2021

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

elasticmachine commented Apr 19, 2021

lizozom left a comment

Choose a reason for hiding this comment

XavierM left a comment

Choose a reason for hiding this comment

patrykkopycinski left a comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 21, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

API count missing comments

History

Dosant commented Mar 30, 2021 •

edited

Loading