[APM] Improve api tests #95636
Merged
[APM] Improve api tests #95636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
commented
Mar 29, 2021
| @@ -29,15 +29,11 @@ export default function customLinksTests({ getService }: FtrProviderContext) { | |||
| ], | |||
| } as CustomLink; | |||
|
|
|||
| try { | |||
| await createCustomLink(customLink); | |||
| expect(true).to.be(false); | |||
There was a problem hiding this comment.
This was quite horrible
sorenlouv
commented
Mar 29, 2021
| } | ||
|
|
||
| return res; | ||
| }; | ||
| } | ||
|
|
||
| export class ApmApiError extends Error { |
|
Pinging @elastic/apm-ui (Team:apm) |
smith
approved these changes
Mar 29, 2021
sorenlouv
added
the
release_note:skip
sorenlouv
added a commit
that referenced
this pull request
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some comments from @smith