-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to verify Console proxy doesn't forward system index header #95562
Add test to verify Console proxy doesn't forward system index header #95562
Conversation
Pinging @elastic/kibana-core (Team:Core) |
Just realized we already had some reservedHeaders validation, going to remove the deprecation I added |
d813059
to
b145b6e
Compare
x-elastic-product-origin
header in ES config and test Console behavior
@elasticmachine merge upstream |
…lastic#95562) * Add test to verify Console API does not forward system index header * Add integration test to Core to verify system indices warning behavior Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these test @joshdover . FWIW, console coverage looks good to me 👍🏻
…95562) (#95666) * Add test to verify Console API does not forward system index header * Add integration test to Core to verify system indices warning behavior Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces·ts.dashboard feature controls spaces space with no features disabled "before all" hook for "shows dashboard navlink"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces·ts.dashboard feature controls spaces space with no features disabled "after all" hook for "can view existing Dashboard"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard Out
Stack Trace
and 15 more failures, only showing the first 3. Metrics [docs]Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
Summary
This is part 1 of #90123
Adds a end-to-end test against the Console
/api/console/proxy
endpoint to verify that the default behavior does not allow passing thex-elastic-product-origin
headerThis PR will be backported to 7.x
Part 2 will target only master/8.0 and it will update the end-to-end test for Console to verify that requests to the
.kibana
alias are always rejectedPart 2 is blocked by Elasticsearch starting to reject requests to external system indices when the header is not set (elastic/elasticsearch#67384). Will defer the remaining parts of #90123 until later in the 7.x cycle.
Checklist
Delete any items that are not applicable to this PR.
For maintainers