Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Send kibana_host when calling /reauth_prepare #95529

Merged
merged 6 commits into from
Mar 30, 2021

Conversation

jgr
Copy link

@jgr jgr commented Mar 26, 2021

Summary

Enterprise Search needs to know the base path of Kibana in order to construct the redirect URL that we pass to the service. We were passing it when constructing the URL for initial authentication, but not re-authentication. This adds it for re-authentication.

@jgr jgr added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes Team:WorkplaceSearch v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 26, 2021
@jgr jgr requested a review from a team March 26, 2021 14:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/workplace-search-frontend (Team:WorkplaceSearch)

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking the lead on this!

@scottybollinger
Copy link
Contributor

@elasticmachine merge upstream

@jgr jgr enabled auto-merge (squash) March 29, 2021 23:51
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB +45.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgr jgr merged commit 4c89da2 into elastic:master Mar 30, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 30, 2021
…stic#95529)

* WIP almost there?

* Fix server route validation

* fix account route

* Fix test expectations

Co-authored-by: scottybollinger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95737

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 30, 2021
) (#95737)

* WIP almost there?

* Fix server route validation

* fix account route

* Fix test expectations

Co-authored-by: scottybollinger <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: James Rucker <[email protected]>
Co-authored-by: scottybollinger <[email protected]>
@jgr jgr deleted the jgr/fix-reauth-prepare branch November 30, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants