[npm] use elastic webpack fork #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Core
w33ble
pushed a commit
that referenced
this pull request
Dec 22, 2016
… (#9540) * [npm] use elastic webpack fork * [webpack] upgrade to @elastic/webpack-directory-name-as-main v2 * bump @elastic/webpack-directory-name-as-main * import browser mocha with webpackShim `import 'mocha'` will resolve to `mocha/index.js`, which points to `mocha/lib/mocha.js`, the node version of mocha. This will not work in the browser. Since ng_mock is browser code, we need the mocha build for the browser, which lives at `mocha/mocha.js`. This isn't referenced at all in the package.json file, but is references in the bower.json file. Webpack, however, doesn't observe the bower config, so we need to specifically reach into the mocha package and point to the `mocha/mocha.js` file.
|
5.x: 9a598fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the package reference to our fork of webpack (see #9497) which was moved to the elastic github org