[TSVB] Enables url drilldowns for range selection #95296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:TSVB
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
dej611
reviewed
Apr 2, 2021
...plugins/vis_type_timeseries/public/application/components/lib/convert_series_to_datatable.ts
Outdated
Show resolved
Hide resolved
dej611
reviewed
Apr 2, 2021
...plugins/vis_type_timeseries/public/application/components/lib/convert_series_to_datatable.ts
Show resolved
Hide resolved
dej611
approved these changes
Apr 2, 2021
|
@elasticmachine merge upstream |
stratoula
changed the title
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Apr 2, 2021
* Temp research code * Make it work * Cleanup * Convert series to datatable * Remove unecessary log * Minor * Fix types problem * Add unit tests * Take under consideration the override index pattern setting * Implement brush event for dual mode * Move indexpatterns fetch outside the loop Co-authored-by: Kibana Machine <[email protected]>
stratoula
added a commit
that referenced
this pull request
Apr 5, 2021
* Temp research code * Make it work * Cleanup * Convert series to datatable * Remove unecessary log * Minor * Fix types problem * Add unit tests * Take under consideration the override index pattern setting * Implement brush event for dual mode * Move indexpatterns fetch outside the loop Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #92164
Until now, TSVB supports only the brush event by using the
APPLY_FILTERtrigger directly. As a result, the user can't create url drilldowns as they require theRANGE_SELECT_TRIGGERinstead.This PR changes the event type and also converts the data to DataTable in order for the event to work properly. The brush event actually requires only the timefilter to work correctly but as we also want to enable filter click on TSVB (currently not supported #83892) I have created the
convertSeriesToDataTablefunction as a step towards this direction.How to test it
Go to Dashboard and create a timeseries TSVB visualization. On edit mode create a url drilldown (license should be updated first). You can see that now, there is an extra option
Range Selection. You can use Discover as theGo to drilldownSave the drilldown, switch to view mode and then brush on the TSVB vis. You should see a popup with the url drilldown you have just created as an option. Click it, it should navigate to Discover with the correct timeframe.
Checklist
Delete any items that are not applicable to this PR.