Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index pattern field editor - Add warning and type 'confirm' on delete or save #95237

Merged
merged 12 commits into from
Mar 26, 2021
Merged

Index pattern field editor - Add warning and type 'confirm' on delete or save #95237

merged 12 commits into from
Mar 26, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Mar 23, 2021 •
edited
Loading

Summary

Add warning regarding potential breakage on removal or change of name or type of runtime field. Also adds index pattern name to flyout header.

Delete modal

Screen Shot 2021-03-24 at 12 32 36 PM

Confirm changes modal

Screen Shot 2021-03-24 at 12 40 32 PM

Flyout header

Screen Shot 2021-03-24 at 12 37 07 PM

Checklist

@mattkime mattkime changed the title add runtime field change/delete confirm dialog Index pattern field editor - Add warning and type 'confirm' on delete or save Mar 23, 2021
@mattkime mattkime added v8.0.0 v7.13.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:AppServices labels Mar 23, 2021
@ryankeairns
Copy link
Contributor

@mattkime I created this PR (mattkime#13) which produces the following results. Feel free to merge.

Delete modal

Screen Shot 2021-03-24 at 12 32 36 PM

Confirm changes modal

Screen Shot 2021-03-24 at 12 40 32 PM

Flyout header

Screen Shot 2021-03-24 at 12 37 07 PM

@mattkime mattkime marked this pull request as ready for review March 25, 2021 17:48
@mattkime mattkime requested a review from a team as a code owner March 25, 2021 17:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexPatternFieldEditor 77.5KB 81.8KB +4.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant self-requested a review March 26, 2021 11:45
Dosant
Dosant approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested 👍

Please note, I didn't test removing multiple fields use-case. I didn't find how to do it in the index pattern editor and assume this isn't implemented there.

@mattkime mattkime merged commit ae4dae4 into elastic:master Mar 26, 2021
mattkime added a commit to mattkime/kibana that referenced this pull request Mar 26, 2021
@mattkime
Index pattern field editor - Add warning and type 'confirm' on delete…
5616104 
… or save (elastic#95237)

* add runtime field change/delete confirm dialog
@mattkime mattkime mentioned this pull request Mar 26, 2021
Merged
mattkime added a commit that referenced this pull request Mar 26, 2021
@mattkime
Index pattern field editor - Add warning and type 'confirm' on delete…
d8c01e6 
… or save (#95237) (#95526)

* add runtime field change/delete confirm dialog
@mattkime mattkime mentioned this pull request Mar 26, 2021
Closed
@mattkime mattkime mentioned this pull request Apr 8, 2021
Merged
1 task
@shaunmcgough shaunmcgough mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @ryankeairns @elasticmachine @kibanamachine @Dosant