Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Adding ES query rule type to stack alerts feature privilege #95225

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Mar 23, 2021

Resolves #95221

Summary

Create a role with limited Kibana privileges, only access to Stack Alerts (read or all). Create a user with that role. Verify that user can go to "Rules and Connectors" page, create an alert and see the Elasticsearch query alert in the list of stack alert types.

@ymao1 ymao1 self-assigned this Mar 23, 2021
@ymao1 ymao1 marked this pull request as ready for review March 23, 2021 20:07
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.13.0 v8.0.0 labels Mar 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the test coverage issue is opened. I didn't find any other place for the feature access definition except the one was fixed. But maybe the person who is more familiar with the RBAC should take a look. Did a local testing as well and all use cases I know is working fine.

@ymao1 ymao1 added the v7.12.1 label Mar 24, 2021
@mikecote mikecote self-requested a review March 24, 2021 13:30
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 24, 2021
@ymao1 ymao1 merged commit d5883be into elastic:master Mar 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 24, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #95307
7.x / #95308

The backport PRs will be merged automatically after passing CI.

@ymao1 ymao1 deleted the alerting/es-query-feature-privilege branch March 25, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alerting] Elasticsearch query rule type not part of stack alerts feature privilege
5 participants