Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip flaky spaces tests #95207

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Unskip flaky spaces tests #95207

merged 2 commits into from
Mar 26, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented Mar 23, 2021 •
edited
Loading

Summary

Flaky test runner results 1: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1397/
Flaky test runner results 2: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1404/

Resolves #27910
Resolves #51942
Resolves #55784
Resolves #63798

@legrego
Copy link
Member Author

legrego commented Mar 25, 2021

My theory was that this flakyness was an artifact of the older (buggier) index patterns implementation. There have been a lot of improvements to this space, and so these tests appear to no longer by flaky.

@legrego
Copy link
Member Author

legrego commented Mar 25, 2021

@elasticmachine merge upstream

@legrego legrego added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Mar 25, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego marked this pull request as ready for review March 26, 2021 11:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from a team March 26, 2021 11:34
@legrego legrego enabled auto-merge (squash) March 26, 2021 12:39
azasypkin
azasypkin approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My theory was that this flakyness was an artifact of the older (buggier) index patterns implementation. There have been a lot of improvements to this space, and so these tests appear to no longer by flaky.

Sounds reasonable to me, let's how it goes!

@legrego legrego merged commit dbd4b2b into elastic:master Mar 26, 2021
@legrego legrego deleted the legrego/issue51942 branch March 26, 2021 14:11
@kibanamachine kibanamachine mentioned this pull request Mar 26, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 26, 2021
@legrego @kibanamachine
Unskip flaky spaces tests (elastic#95207)
a68639c 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95527

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 26, 2021
@kibanamachine @legrego
Unskip flaky spaces tests (#95207) (#95527)
fe3a6e0 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Larry Gregory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@legrego @kibanamachine @elasticmachine @azasypkin