Make alerting tests use new rules APIs #95159

mikecote · 2021-03-23T13:34:55Z

⚠️ This PR merges into a feature branch

Converts the API integration tests to solely use the new APIs from Create new rule HTTP APIs #93980
Converts the end to end tests to use the new APIs from Create new rule HTTP APIs #93980

Note: To keep this PR small, I left out adding API integration coverage for our legacy APIs. This will be done as a follow up in #93977.

…bana into alerting/test-new-apis

mikecote · 2021-03-24T15:20:09Z

x-pack/plugins/alerting/server/routes/find_rules.ts

@@ -20,7 +21,7 @@ const querySchema = schema.object({
  default_search_operator: schema.oneOf([schema.literal('OR'), schema.literal('AND')], {
    defaultValue: 'OR',
  }),
-  search_fields: schema.maybe(schema.arrayOf(schema.string())),
+  search_fields: schema.maybe(schema.oneOf([schema.arrayOf(schema.string()), schema.string()])),


I had to add this back to support ?search_fields=foo, which was caught in our tests.

elasticmachine · 2021-03-24T15:28:11Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko

LGTM

ymao1

LGTM

x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/list_alert_types.ts

kibanamachine · 2021-03-25T14:32:16Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #114875 succeeded 4d6722c
💔 Build #114854 failed 8c447f1
💔 Build #114556 failed e8ce075

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

* Move current alert HTTP APIs to legacy folder (#93943) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Create new rule HTTP APIs (#93980) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Move current alert HTTP APIs to legacy folder (#93943) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Add necessary files * Create rule route * Get rule API * Update rule API * Delete rule route * Aggregate rules API * Disable rule API * Enable rule API * Find rules API * Fix Update API * Get rule alert summary API * Get rule state API * Health API * Rule types API * Mute all API * Mute alert API * Unmute all API * Unmute alert route * Update API key API * corrected tpye by making it much more complicated * removed unneeded cocde * Fixes * Add back health route * mutedInstanceIds -> mutedAlertIds * lastRun -> last_run * alert_type_state -> rule_type_state & alert_instances -> alerts Co-authored-by: Gidi Meir Morris <[email protected]> * Create docs for new rule HTTP APIs, deprecate old docs (#94745) * Create docs for new APIs, deprecate old docs * Remove connector_type_id * Update docs * Add link to legacy APIs from rules API docs * Remove connector_type_id references * [DOCS] Add legacy APIs to index.asciidoc * Fix camel case Co-authored-by: lcawl <[email protected]> * Make alerting tests use new rules APIs (#95159) * Make API integration tests use new HTTP APIs * Fix end to end tests * Fix test failures * Fix more test failures * Rename some files * Add tests for legacy APIs (#95333) * Initial commit (#95457) * Move some new alerting APIs to /internal (#95461) * Initial commit * Update README.md * Use internal API * Merge deprecated warning w/ alternative solution * Update API docs Co-authored-by: Gidi Meir Morris <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: lcawl <[email protected]>

…3977) * Move current alert HTTP APIs to legacy folder (elastic#93943) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Create new rule HTTP APIs (elastic#93980) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Move current alert HTTP APIs to legacy folder (elastic#93943) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Add necessary files * Create rule route * Get rule API * Update rule API * Delete rule route * Aggregate rules API * Disable rule API * Enable rule API * Find rules API * Fix Update API * Get rule alert summary API * Get rule state API * Health API * Rule types API * Mute all API * Mute alert API * Unmute all API * Unmute alert route * Update API key API * corrected tpye by making it much more complicated * removed unneeded cocde * Fixes * Add back health route * mutedInstanceIds -> mutedAlertIds * lastRun -> last_run * alert_type_state -> rule_type_state & alert_instances -> alerts Co-authored-by: Gidi Meir Morris <[email protected]> * Create docs for new rule HTTP APIs, deprecate old docs (elastic#94745) * Create docs for new APIs, deprecate old docs * Remove connector_type_id * Update docs * Add link to legacy APIs from rules API docs * Remove connector_type_id references * [DOCS] Add legacy APIs to index.asciidoc * Fix camel case Co-authored-by: lcawl <[email protected]> * Make alerting tests use new rules APIs (elastic#95159) * Make API integration tests use new HTTP APIs * Fix end to end tests * Fix test failures * Fix more test failures * Rename some files * Add tests for legacy APIs (elastic#95333) * Initial commit (elastic#95457) * Move some new alerting APIs to /internal (elastic#95461) * Initial commit * Update README.md * Use internal API * Merge deprecated warning w/ alternative solution * Update API docs Co-authored-by: Gidi Meir Morris <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: lcawl <[email protected]> # Conflicts: # api_docs/core.json

…95781) * Move current alert HTTP APIs to legacy folder (#93943) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Create new rule HTTP APIs (#93980) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Move current alert HTTP APIs to legacy folder (#93943) * Move current HTTP APIs to legacy folder * Rename BASE_ALERT_API_PATH to LEGACY_BASE_ALERT_API_PATH * Fix failing tests and extra files * Add necessary files * Create rule route * Get rule API * Update rule API * Delete rule route * Aggregate rules API * Disable rule API * Enable rule API * Find rules API * Fix Update API * Get rule alert summary API * Get rule state API * Health API * Rule types API * Mute all API * Mute alert API * Unmute all API * Unmute alert route * Update API key API * corrected tpye by making it much more complicated * removed unneeded cocde * Fixes * Add back health route * mutedInstanceIds -> mutedAlertIds * lastRun -> last_run * alert_type_state -> rule_type_state & alert_instances -> alerts Co-authored-by: Gidi Meir Morris <[email protected]> * Create docs for new rule HTTP APIs, deprecate old docs (#94745) * Create docs for new APIs, deprecate old docs * Remove connector_type_id * Update docs * Add link to legacy APIs from rules API docs * Remove connector_type_id references * [DOCS] Add legacy APIs to index.asciidoc * Fix camel case Co-authored-by: lcawl <[email protected]> * Make alerting tests use new rules APIs (#95159) * Make API integration tests use new HTTP APIs * Fix end to end tests * Fix test failures * Fix more test failures * Rename some files * Add tests for legacy APIs (#95333) * Initial commit (#95457) * Move some new alerting APIs to /internal (#95461) * Initial commit * Update README.md * Use internal API * Merge deprecated warning w/ alternative solution * Update API docs Co-authored-by: Gidi Meir Morris <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: lcawl <[email protected]> # Conflicts: # api_docs/core.json

mikecote added 3 commits March 23, 2021 08:43

Make API integration tests use new HTTP APIs

80f1782

Merge branch 'alerting/http-api-terminology' of github.com:elastic/ki…

1d73940

…bana into alerting/test-new-apis

Fix end to end tests

e8ce075

mikecote added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 23, 2021

mikecote self-assigned this Mar 23, 2021

mikecote changed the base branch from master to alerting/http-api-terminology March 23, 2021 13:35

mikecote mentioned this pull request Mar 23, 2021

Create new alerting HTTP APIs that use the new terminology #93977

Merged

7 tasks

mikecote added 2 commits March 24, 2021 07:42

Fix test failures

8c447f1

Fix more test failures

4d6722c

mikecote commented Mar 24, 2021

View reviewed changes

mikecote marked this pull request as ready for review March 24, 2021 15:28

mikecote requested a review from a team as a code owner March 24, 2021 15:28

YulNaumenko approved these changes Mar 25, 2021

View reviewed changes

ymao1 approved these changes Mar 25, 2021

View reviewed changes

x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/list_alert_types.ts Show resolved Hide resolved

Rename some files

f53a57a

mikecote merged commit 354e3ec into elastic:alerting/http-api-terminology Mar 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make alerting tests use new rules APIs #95159

Make alerting tests use new rules APIs #95159

mikecote commented Mar 23, 2021

mikecote Mar 24, 2021

elasticmachine commented Mar 24, 2021

YulNaumenko left a comment

ymao1 left a comment

kibanamachine commented Mar 25, 2021

Make alerting tests use new rules APIs #95159

Make alerting tests use new rules APIs #95159

Conversation

mikecote commented Mar 23, 2021

⚠️ This PR merges into a feature branch

mikecote Mar 24, 2021

Choose a reason for hiding this comment

elasticmachine commented Mar 24, 2021

YulNaumenko left a comment

Choose a reason for hiding this comment

ymao1 left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 25, 2021

💚 Build Succeeded

Metrics [docs]

History