View/edit mode for dashboards #9508

stacey-gammon · 2016-12-15T17:39:10Z

Implementation of #9431

epixa · 2016-12-26T20:27:56Z

Looks like the build failed on this one

stacey-gammon · 2016-12-27T13:57:30Z

jenkins test this

kobelb

This is awesome, I really like it.

My only concern is that while editing a dashboard, the user can click the 'Stop Editing' button without saving their changes. I could see a user hit 'Stop Editing' as opposed to 'Save' and assuming the changes that they made were saved, because it kinda looks like it.

kobelb · 2016-12-20T21:59:46Z

src/core_plugins/kibana/public/dashboard/get_top_nav_config.js

+
+function getViewConfig(modeChange) {
+  return createTopNavExecuteConfig(
+    'Stop Editing',


Small nitpick, the 'key' for this config doesn't match the others.

because of the case? I did that on purpose because I want the second word capitalized. The first word gets auto capitalized but the second doesn't. I could do stop editing and it'll show up as Stop editing but I didn't like that. I could do stop Editing but that's weird too. I suppose I could also find where these words are capitalized and capitalize every word there, but that might affect other tabs. I'll revert to stop editing to be consistent here and we can decide on the casing later, and change it for all or nothing.

Sorry, please disregard this entirely. I made this comment a while ago, and it's no longer valid.

stacey-gammon · 2017-01-02T15:43:01Z

Hmm, that's a really good observation. I see two ways to fix this.

Add a warning if unsaved changes are detected. I think this will be trivial to implement as I heard there is already a dirty flag, but I haven't confirmed yet.
or
We make Stop Editing auto save. My concern with this is if the person doesn't want to save their changes. Although they do have a way around this - by refreshing the page - but it's not super clear that Stop Editing will save the dash.

I think in most cases #2 would be a better UX, but #1 is safer.

Thoughts? Any input on this @cjcenizal?

kobelb · 2017-01-02T15:44:36Z

Part of me wonders whether having a single 'Save/Cancel Editing' button that changes based on the appState.isDirty would be sufficient.

kobelb · 2017-01-02T15:47:19Z

On second thought, maybe always having a 'Save' and 'Cancel Editing' button would be better than my previous suggestion, and disable the Save button before there are changes. I liked your idea about showing the user when there are unsaved changes as well, but I dunno if my idea about disabling the 'Save' button would be clear enough.

epixa · 2017-01-02T16:20:19Z

How about a toaster message (not red) when they switch to view mode with unsaved changes? Without better test coverage (both unit and integration) around the dirty flag, we probably should not be disabling the save capability on it. We've had issues already with it not being entirely reliable with reporting in x-pack.

and implement new angular style suggestions from Joe

no point making vanilla code that's really only going to work with angular i guess... also broke apart the confirm modal from the injector, and made safeConfirm just use the confirm modal

- Move safe_confirm into modals folder - make data-test-subj camelCase. - get rid of $timeout call, doesn’t seem necessary anymore, now that window.confirm is not being used.

and fix some bugs NOTE: code is a mess. Once UX is nailed down I’ll clean it up.

stacey-gammon · 2017-01-19T19:23:09Z

Things required before this PR can move forward:

Dashboard landing page. PR
Breadcrumbs - In landing page PR
Removal of Open and New nav options (same PR above)
Switch Stop Editing to Done
Outlines always on in edit mode.
Stay in edit mode if navigating in kibana (store mode in state).
Stylize Done to call it out.
Clean up code

Maybe required:

Better distinguishing between objects with duplicate names

Figure out later:

Navigating away with unsaved changes (an existing problem)
Get rid of save panel - move to options/rename/duplicate.

Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options

improve tests

- Add new landing page empty text (merge) - Make view mode stateful

stacey-gammon mentioned this pull request Dec 15, 2016

Edit/view dashboard mode (WIP) #9398

Closed

stacey-gammon force-pushed the view-edit-mode branch 2 times, most recently from d6941f8 to c58984b Compare December 15, 2016 18:17

stacey-gammon added the review label Dec 15, 2016

stacey-gammon requested review from kobelb and cjcenizal December 15, 2016 18:19

stacey-gammon force-pushed the view-edit-mode branch from c58984b to abefdcc Compare December 15, 2016 19:56

tbragin added Feature:Dashboard Dashboard related features :Sharing labels Dec 16, 2016

stacey-gammon force-pushed the view-edit-mode branch 2 times, most recently from 9f52531 to 8140f2b Compare December 20, 2016 18:50

stacey-gammon assigned kobelb and cjcenizal Dec 20, 2016

cjcenizal mentioned this pull request Dec 22, 2016

Allow users to easily change the Visualization displayed in a Dashboard panel #7917

Closed

epixa added updates_needed and removed review labels Dec 26, 2016

epixa added review and removed updates_needed labels Dec 27, 2016

stacey-gammon force-pushed the view-edit-mode branch 2 times, most recently from 0d59125 to d080e3e Compare December 28, 2016 15:30

epixa changed the title ~~View edit mode~~ View/edit mode for dashboards Dec 28, 2016

stacey-gammon force-pushed the view-edit-mode branch from d080e3e to a8e2fd3 Compare December 30, 2016 16:15

kobelb reviewed Jan 2, 2017

View reviewed changes

stacey-gammon force-pushed the view-edit-mode branch from 28891a1 to 2535116 Compare January 2, 2017 15:47

stacey-gammon and others added 13 commits January 19, 2017 10:20

Add help text for empty dashboard in view mode

5d664b6

Track changes to time filter manually

496feb3

Introduce custom modal confirmation dialogs

4668e7e

address code review comments

c9840ef

and implement new angular style suggestions from Joe

refactor

c4b4339

no point making vanilla code that's really only going to work with angular i guess... also broke apart the confirm modal from the injector, and made safeConfirm just use the confirm modal

Clean up from merge

7ab784e

- Move safe_confirm into modals folder - make data-test-subj camelCase. - get rid of $timeout call, doesn’t seem necessary anymore, now that window.confirm is not being used.

Fix tests

cf3abc2

Use ui-framework styles

58b0174

incorporate new modal dialogs

b423dbc

and fix some bugs NOTE: code is a mess. Once UX is nailed down I’ll clean it up.

Add ability to cancel out of confirm dialogs

fd77a3c

Bug fix and clean up dialog

012667d

Bug fix and customize filter warning dialog

3c5e4bf

Merge with master

17a130c

stacey-gammon force-pushed the view-edit-mode branch from c5265f7 to 17a130c Compare January 19, 2017 15:40

Fix bug and modify unsaved changes warning

0f8c774

stacey-gammon added 6 commits January 23, 2017 09:40

Introduce dashboard landing page

8c8da92

Still TODO: - Add clickable breadcrumbs - Remove New and Open top nav options

use clickable breadcrumbs instead of 'New' and 'Open' nav items

2dbfea7

code cleanup

d9cf7d3

improve tests

Merge dashboard-landing-page

410a384

Show edit style always in edit mode

5a1c133

- Add new landing page empty text (merge) - Make view mode stateful

Use done instead of stop editing

271b5e1

alexfrancoeur mentioned this pull request Jan 31, 2017

Improve workflow for drill-down from chart to individual documents #10057

Closed

epixa removed the v5.3.0 label Feb 10, 2017

stacey-gammon closed this Feb 14, 2017

stacey-gammon mentioned this pull request Mar 8, 2017

View Mode: Reload saved dashboard on page refresh #10727

Closed

stacey-gammon deleted the view-edit-mode branch April 6, 2017 11:08

snyk-bot mentioned this pull request Apr 28, 2020

[Snyk] Security upgrade mapbox-gl from 0.54.0 to 1.10.0 larrycameron80/kibana#26

Open

snyk-bot mentioned this pull request Mar 22, 2022

[Snyk] Fix for 1 vulnerabilities larrycameron80/kibana#121

Open

larrycameron80 mentioned this pull request Nov 28, 2023

[Snyk] Fix for 3 vulnerabilities larrycameron80/kibana#177

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

View/edit mode for dashboards #9508

View/edit mode for dashboards #9508

stacey-gammon commented Dec 15, 2016 •

edited

Loading

epixa commented Dec 26, 2016

stacey-gammon commented Dec 27, 2016

kobelb left a comment •

edited

Loading

kobelb Dec 20, 2016

stacey-gammon Jan 2, 2017

kobelb Jan 2, 2017

stacey-gammon commented Jan 2, 2017

kobelb commented Jan 2, 2017

kobelb commented Jan 2, 2017

epixa commented Jan 2, 2017

stacey-gammon commented Jan 19, 2017 •

edited

Loading

View/edit mode for dashboards #9508

View/edit mode for dashboards #9508

Conversation

stacey-gammon commented Dec 15, 2016 • edited Loading

epixa commented Dec 26, 2016

stacey-gammon commented Dec 27, 2016

kobelb left a comment • edited Loading

Choose a reason for hiding this comment

kobelb Dec 20, 2016

Choose a reason for hiding this comment

stacey-gammon Jan 2, 2017

Choose a reason for hiding this comment

kobelb Jan 2, 2017

Choose a reason for hiding this comment

stacey-gammon commented Jan 2, 2017

kobelb commented Jan 2, 2017

kobelb commented Jan 2, 2017

epixa commented Jan 2, 2017

stacey-gammon commented Jan 19, 2017 • edited Loading

stacey-gammon commented Dec 15, 2016 •

edited

Loading

kobelb left a comment •

edited

Loading

stacey-gammon commented Jan 19, 2017 •

edited

Loading