Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix readme for running tsc #95074

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[APM] Fix readme for running tsc #95074

merged 1 commit into from
Mar 22, 2021

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Mar 22, 2021 •
edited
Loading

Running yarn tsc --noEmit --project x-pack/plugins/apm/tsconfig.json --skipLibCheck gave the following error

x-pack/plugins/apm/tsconfig.json:6:5 - error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.

6     "emitDeclarationOnly": true,
      ~~~~~~~~~~~~~~~~~~~~~


Found 1 error.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Adding --emitDeclarationOnly false seems to fix it

@sorenlouv sorenlouv requested a review from a team as a code owner March 22, 2021 16:23
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 22, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit e90e5ba into master Mar 22, 2021
@sorenlouv sorenlouv deleted the apm-readme branch March 22, 2021 22:20
@sorenlouv sorenlouv added auto-backport Deprecated - use backport:version if exact versions are needed v7.10.0 v7.11.0 v7.12.0 v8.0.0 labels Mar 22, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 22, 2021
@sorenlouv @kibanamachine
[APM] Fix readme for running tsc (elastic#95074)
1b4ea59
@kibanamachine kibanamachine mentioned this pull request Mar 22, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 22, 2021
@sorenlouv @kibanamachine
[APM] Fix readme for running tsc (elastic#95074)
c568d24
@kibanamachine kibanamachine mentioned this pull request Mar 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.10: Commit could not be cherrypicked due to conflicts
❌ 7.11: Commit could not be cherrypicked due to conflicts
✅ 7.12 / #95118
✅ 7.x / #95119

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 95074

kibanamachine added a commit that referenced this pull request Mar 23, 2021
@kibanamachine @sorenlouv
[APM] Fix readme for running tsc (#95074) (#95118)
0f26a41 
Co-authored-by: Søren Louv-Jansen <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 23, 2021
@kibanamachine @sorenlouv
[APM] Fix readme for running tsc (#95074) (#95119)
432649b 
Co-authored-by: Søren Louv-Jansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorenlouv @elasticmachine @kibanamachine @ogupte