Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Kibana Application Privileges for Reporting #94966
[Reporting] Kibana Application Privileges for Reporting #94966
Changes from 4 commits
114e6fe
fe4d0b6
dc1389d
7ffecd5
3827e2d
29fb231
9b675f9
d2e17a9
84e881b
3110eb5
0242a40
4bf0d25
3e4d71b
4cb82e3
c293f11
9505e17
1343dca
e25809c
7ae6eff
10b9424
2bc67aa
edd866b
6a0575b
118f6db
93918be
c8888e2
9a972fb
0bf2761
7b8acb1
1c0328f
22de10f
fd47295
34b72c5
c6f912d
26f59ba
67fdf72
5d87201
525305b
1a03dac
eec188c
2e732f2
c5cc50e
4e90797
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad break on this line. Are the spaces before and after "reporting_user" needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this title as you changed the previous title that started with "If you are using..." Would "With an external provider" work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "When using an external provider"?
This is a higher-level heading than the title that you mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
...(includeReporting ? [{}] : [])
would avoid the boolean filtering at the end.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will leave a visible gap for a user that does not have the privilege:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant
...(includeReporting ? [{LINK}] : [])
,{LINK}
being the object you're currently adding.