Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update Angular styleguide. #9495

Closed
wants to merge 1 commit into from
Closed

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Dec 15, 2016

Addresses #9049

Since this is a collaborative effort, let's make PRs into this branch and merge them (no review needed). Then we can do a final review of this PR alone.

References

new rules completed through to services, the rest is pulled directly from the john-papa styleguide
@cjcenizal cjcenizal requested review from w33ble and spalger December 15, 2016 00:23
@cjcenizal cjcenizal changed the title Update Angular styleguide. [WIP] Update Angular styleguide. Dec 15, 2016
@cjcenizal cjcenizal added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v5.2.0 v6.0.0 labels Dec 15, 2016
@spalger spalger self-assigned this Dec 16, 2016
@w33ble w33ble self-assigned this Dec 16, 2016
@epixa epixa added v5.2.1 and removed v5.2.0 labels Jan 31, 2017
@epixa epixa added v5.2.2 and removed v5.2.1 labels Feb 7, 2017
@cjcenizal cjcenizal added v5.4.0 and removed v5.2.2 labels Feb 9, 2017
@w33ble
Copy link
Contributor

w33ble commented Apr 10, 2017

@cjcenizal @spalger do we care about this anymore? With the intention to move to react, this seems pretty unimportant.

@cjcenizal
Copy link
Contributor Author

I agree. Closing.

@cjcenizal cjcenizal closed this Apr 10, 2017
@epixa epixa deleted the enh/new-angular-styleguide branch June 23, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v5.4.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants