[Security Solution] fix data providers cypress tests #94933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
v7.12.0
v7.13.0
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
x-pack/plugins/security_solution/cypress/integration/timelines/data_providers.spec.ts
Outdated
Show resolved
Hide resolved
MadameSheema
approved these changes
Mar 22, 2021
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Mar 22, 2021
* fix data providers cypress tests * add scrollToBottom to common tasks file Co-authored-by: Kibana Machine <[email protected]>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Mar 22, 2021
* fix data providers cypress tests * add scrollToBottom to common tasks file Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/security_solution/cypress/integration/timelines/data_providers.spec.ts # x-pack/plugins/security_solution/cypress/integration/timelines/flyout_button.spec.ts
angorayc
added a commit
that referenced
this pull request
Mar 22, 2021
* fix data providers cypress tests * add scrollToBottom to common tasks file Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/security_solution/cypress/integration/timelines/data_providers.spec.ts # x-pack/plugins/security_solution/cypress/integration/timelines/flyout_button.spec.ts
angorayc
added a commit
that referenced
this pull request
Mar 22, 2021
* fix data providers cypress tests * add scrollToBottom to common tasks file Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Closes and opens alerts.Closing alerts Closes and opens alertsStack TraceKibana Pipeline / general / "before all" hook for "should contain the right query".Timeline query tab Query tab "before all" hook for "should contain the right query"Stack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to unskip the tests here: #94576
In the test of data provider, I no longer check the style of the element, but the classes added instead. Hope this could reduce flakiness and the influence of EUI change as well.