Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY SOLUTIONS] Bug top-n alerts #94920

Merged
merged 10 commits into from
Mar 23, 2021
Merged

[SECURITY SOLUTIONS] Bug top-n alerts #94920

merged 10 commits into from
Mar 23, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Mar 18, 2021 •
edited
Loading

Summary

Bugs:

Checklist

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 18, 2021
@XavierM XavierM self-assigned this Mar 18, 2021
@XavierM XavierM requested a review from a team as a code owner March 18, 2021 13:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

andrew-goldstein
andrew-goldstein approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes and the additional tests @XavierM 🙏

✅ Top N aggregations are applying the correct indexes and filter criteria in both table and Timeline views, in both raw and alert modes
✅ Desk tested locally in:

  • Chrome 89.0.4389.90
  • Firefox 86.0.1
  • Safari 14.0.3

LGTM

@XavierM
Copy link
Contributor Author

XavierM commented Mar 19, 2021

@elasticmachine merge upstream

@XavierM
Copy link
Contributor Author

XavierM commented Mar 22, 2021

@elasticmachine merge upstream

@XavierM
Copy link
Contributor Author

XavierM commented Mar 23, 2021

@elasticmachine merge upstream

@XavierM XavierM enabled auto-merge (squash) March 23, 2021 15:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2204 2205 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.2MB 7.2MB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @XavierM

@XavierM XavierM merged commit 8a42049 into elastic:master Mar 23, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 23, 2021
@XavierM @kibanamachine
[SECURITY SOLUTIONS] Bug top-n alerts (elastic#94920)
0a1450f 
* Associate timeline filter/query/dataprovider to top-n for alerts events

* fix pinned view when opening details panel

* fix top-n to bring the right raw/all indices

* review + do not add filter/query/dataprovider on Correlation/Pinned tab for topN

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Mar 23, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 23, 2021
@XavierM @kibanamachine
[SECURITY SOLUTIONS] Bug top-n alerts (elastic#94920)
bfba27f 
* Associate timeline filter/query/dataprovider to top-n for alerts events

* fix pinned view when opening details panel

* fix top-n to bring the right raw/all indices

* review + do not add filter/query/dataprovider on Correlation/Pinned tab for topN

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Mar 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

✅ 7.12 / #95208
✅ 7.x / #95209
❌ 7.14: The branch "7.14" is invalid or doesn't exist

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 94920

kibanamachine added a commit that referenced this pull request Mar 23, 2021
@kibanamachine @XavierM
[SECURITY SOLUTIONS] Bug top-n alerts (#94920) (#95208)
e7d73b1 
* Associate timeline filter/query/dataprovider to top-n for alerts events

* fix pinned view when opening details panel

* fix top-n to bring the right raw/all indices

* review + do not add filter/query/dataprovider on Correlation/Pinned tab for topN

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 23, 2021
@kibanamachine @XavierM
[SECURITY SOLUTIONS] Bug top-n alerts (#94920) (#95209)
8ce4213 
* Associate timeline filter/query/dataprovider to top-n for alerts events

* fix pinned view when opening details panel

* fix top-n to bring the right raw/all indices

* review + do not add filter/query/dataprovider on Correlation/Pinned tab for topN

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Xavier Mouligneau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@XavierM XavierM

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XavierM @elasticmachine @kibanamachine @andrew-goldstein