Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Use consistent-type-imports lint rule to autofix type-only imports (#94464) #94868

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Mar 17, 2021

Backports the following commits to 7.x:

…94464)

## Summary

Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible

Code-only changes like this were recently added in #92979, but it was a more manual process.  This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️
# Conflicts:
#	x-pack/plugins/fleet/server/services/agents/crud.ts
#	x-pack/plugins/fleet/server/services/artifacts/artifacts.ts
#	x-pack/plugins/fleet/server/services/artifacts/mappings.ts
#	x-pack/plugins/fleet/server/services/artifacts/mocks.ts
#	x-pack/plugins/fleet/server/services/index.ts
@jfsiii jfsiii enabled auto-merge (squash) March 17, 2021 21:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit ad36e8c into elastic:7.x Mar 17, 2021
@jfsiii jfsiii deleted the backport/7.x/pr-94464 branch April 6, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants