-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Reorganize folder structure #94843
[Upgrade Assistant] Reorganize folder structure #94843
Conversation
…organize_folder_structure
…organize_folder_structure
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…organize_folder_structure
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me too!
I was just thinking, qualifying directory names beyond elasticsearch
and kibana
(to something like elasticsearch_deprecations
or elasticsarch_issues
) would mentally narrow down what I might expect to find these folders. Just a thought, other than looks great!
…organize_folder_structure
That's a great point! I've renamed the ES folder to |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
This PR reorganizes the
public
folder structure in preparation for supporting Kibana deprecations. The main change is flattening thecomponents
directory by removing thetabs
directory, and renaming thecheckup
directory toelasticsearch
.Current folder structure:
New folder structure:
How to review
Most of the changes in this PR are all related to updating import paths and renaming files. The main thing to review is the new folder structure outlined above and verify it makes sense moving forward.