[Component templates] Fix failing API test #94831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
Feature:Index Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
This PR will probably fail until the snapshot is promoted with the change. A couple options that come to mind:
|
|
👍 thanks @tylersmalley! I've skipped the test for now, and can open up a follow-up PR to re-enable. |
tylersmalley
added
the
auto-backport
tylersmalley
approved these changes
Mar 17, 2021
|
Thanks, will merge, kick off a snapshot and report back when it's available. Snapshot verifications: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 17, 2021
* fix failing component templates test * temporarily skip test
tylersmalley
pushed a commit
that referenced
this pull request
Mar 17, 2021
* fix failing component templates test * temporarily skip test Co-authored-by: Alison Goryachev <[email protected]>
💔 Build Failed
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94773
The ES team recently merged elastic/elasticsearch#70314, which adds support for deleting multiple component templates. As part of this change, it looks like the error message returned when a component template doesn't exist was changed from
IndexTemplateMissingExceptiontoResourceNotFoundException(which is more appropriate). This PR updates the expected error message in the test.As a follow-up, we should consider using the updated API rather than making a delete request per component template for bulk deletes. Since this failed test is preventing the promotion of the current Elasticsearch nightly snapshot, I think that enhancement is best addressed separately.