-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote clusters] Cloud deployment form when adding new cluster #94450
Merged
yuliacech
merged 46 commits into
elastic:master
from
yuliacech:remote_clusters_cloud_form_2
Apr 8, 2021
Merged
Changes from 5 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
e88f2d9
Implemented in-form Cloud deployment url input
yuliacech 61eee0b
Fixed i18n files and added mode switch back for non-Cloud
yuliacech 134d063
Merge branch 'master' into remote_clusters_cloud_form_2
yuliacech 24ee218
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 800c9ce
Added cloud docs link to the documentation service, fixed snapshot tests
yuliacech 2631c2c
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 28d6fb0
Fixed docs build
yuliacech 907ae2f
Added jest test for the new cloud url input
yuliacech 94d626b
Merge branch 'master' into remote_clusters_cloud_form_2
yuliacech d7e1417
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 82eae18
Merge branch 'master' into remote_clusters_cloud_form_2
yuliacech 1ac351a
Added unit test for cloud validation
yuliacech 68e9cc8
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 2229208
Fixed eslint error
yuliacech 8b93354
Fixed ts errors
yuliacech 1d134ef
Added ts-ignore
yuliacech 2d5f0ae
Fixed ts errors
yuliacech 801b61c
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine ac5c03e
Refactored connection mode component and component tests
yuliacech c7ffc93
Fixed import
yuliacech fce253c
Fixed copy
yuliacech 908f11d
Fixed copy
yuliacech 70f3d80
Reverted docs changes
yuliacech 5313f5b
Reverted docs changes
yuliacech 94b072d
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 01075ac
Merge branch 'master' into remote_clusters_cloud_form_2
yuliacech f037d19
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine d2413bc
Replaced the screenshot with a popover and refactored integration tests
yuliacech de89802
Added todo for cloud deployments link
yuliacech b2161e9
Changed cloud URL help text copy
yuliacech a9e317c
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 6b9793c
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 8a2a200
Added cloud base url and deleted unnecessary base path
yuliacech bfa86b7
Fixed es error
yuliacech ee1af7c
Fixed es error
yuliacech 8dafc20
Changed wording
yuliacech f5c1dba
Reverted docs changes
yuliacech 85655c1
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine d157ddd
Updated the help popover
yuliacech 2fa7a72
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 95a06eb
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 9e2ab0d
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine a2c811e
Merge branch 'master' into remote_clusters_cloud_form_2
kibanamachine 205aa4f
Deleted unneeded fragment component
yuliacech 9c46850
Deleted unneeded fragment component
yuliacech e0d85ee
Updated tests descriptions to be more detailed
yuliacech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
DOC_LINK_VERSION
in the url here instead ofcurrent
?