adding kibana filter expression functions #94069

ppisljar · 2021-03-09T10:53:52Z

Summary

kibanaFilter, rangeFilter, existsFilter and phraseFilter expression functions were added which all generate kibanaFilter type.

filtersToAst utility function was added which takes a Filter or array of them and returns array of expressions

kibana_context expression function was updated to take kibanaFilter type in as filters argument and all the places using it were updated.

resolves #67896

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-03-09T10:54:35Z

Pinging @elastic/kibana-app-services (Team:AppServices)

kibanamachine · 2021-03-17T17:15:49Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: ea2152df75b695fbd57c58e29c98635563ddef33
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

💔 Build #113685 failed 14a02378bd2d4754419f45bd23e28ee290b20e0f
💔 Build #113329 failed 4133707b70198da6284766735235c51075f60a15
💔 Build #113198 failed 4895426f310d22b9b0ac6189d2ae5d5fa75587e9
💔 Build #112438 failed 3a6ed1775938bba47b9e0a3a1c0ed968182d933e
💔 Build #112421 failed 7c529f5ce1e6faa7b345dbc4a72b72fdd834b967

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ssion functions

streamich

Code changes LGTM, except the lt, lte, gt and gte checks, see below.

streamich · 2021-03-23T08:13:31Z

src/plugins/data/common/search/expressions/exists_filter.test.ts

+  });
+
+  it('returns an object with the correct structure', () => {
+    const actual = fn(null, { field: { spec: { name: 'test' } } }, context);


I understand this is copy-paste from similar tests in this plugin, but I've seen it a lot and wanted to suggest a small improvement. It is better to not create global module variables, like context here and not use beforeEach utility, which is specific to Jest. This can be done like so:

Suggested change

const actual = fn(null, { field: { spec: { name: 'test' } } }, context);

const context = setup();

const actual = fn(null, { field: { spec: { name: 'test' } } }, context);

Simply setup() function that creates everything needed for each test case every time.

src/plugins/data/common/search/expressions/exists_filter.ts

src/plugins/data/common/search/expressions/field.ts

src/plugins/data/common/search/expressions/filters_to_ast.test.ts

streamich · 2021-03-23T08:26:17Z

src/plugins/data/common/search/expressions/kibana_filter.test.ts

+    };
+  });
+
+  it('returns an object with the correct structure', () => {


Same here, fn and context are defined outside of the text case, and the test case name just says that something should work "correctly", but it is not clear what should be correct, and it is not clear why fn and context are coming from out of the test case.

src/plugins/data/common/search/expressions/range.ts

stratoula

Kibana app code changes LGTM!

dokmic

LGTM

Co-authored-by: Vadim Dalecky <[email protected]>

kibanamachine · 2021-03-23T16:02:50Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`data`	616	623	+7
`expressions`	149	151	+2
total			+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`data`	202.1KB	202.1KB	-2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	772.2KB	780.3KB	+8.1KB
`expressions`	192.6KB	193.3KB	+798.0B
`visualizations`	107.3KB	107.4KB	+72.0B
total			+9.0KB

History

💚 Build #114480 succeeded 57b3d71
💔 Build #114392 failed 7bbbe60
💔 Build #114344 failed 0fbb0ff
💔 Build #114309 failed 3daaa59
💔 Build #113908 failed a09746ba0777ea686f59e455f9561a720cf6b66c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ppisljar requested a review from a team March 9, 2021 10:53

ppisljar requested a review from a team as a code owner March 9, 2021 10:53

ppisljar added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppServices v7.13.0 v8.0.0 WIP Work in progress labels Mar 9, 2021

ppisljar added the release_note:skip Skip the PR/issue when compiling release notes label Mar 9, 2021

ppisljar force-pushed the expressions/filter_functions branch 2 times, most recently from 4895426 to 4133707 Compare March 16, 2021 10:50

ppisljar force-pushed the expressions/filter_functions branch from 4133707 to 14a0237 Compare March 17, 2021 16:03

ppisljar force-pushed the expressions/filter_functions branch from ea2152d to a09746b Compare March 18, 2021 06:55

ppisljar added 3 commits March 22, 2021 12:57

adding kibanaFilter, rangeFilter, existsFilter and phraseFilter expre…

6fed6da

…ssion functions

fixes

e7e0020

fixes

3daaa59

ppisljar force-pushed the expressions/filter_functions branch from a09746b to 3daaa59 Compare March 22, 2021 14:17

ppisljar and others added 4 commits March 22, 2021 16:17

fixes

0fbb0ff

fixes

7ec0933

Refactor filters unboxing

7bbbe60

fixes

57b3d71

ppisljar added review and removed WIP Work in progress labels Mar 23, 2021

streamich approved these changes Mar 23, 2021

View reviewed changes

stratoula approved these changes Mar 23, 2021

View reviewed changes

dokmic approved these changes Mar 23, 2021

View reviewed changes

ppisljar and others added 2 commits March 23, 2021 14:44

Apply suggestions from code review

9722fb9

Co-authored-by: Vadim Dalecky <[email protected]>

improving tests

bdbc1d1

ppisljar merged commit edb9453 into elastic:master Mar 23, 2021

ppisljar mentioned this pull request Mar 24, 2021

[7.x] adding kibana filter expression functions (#94069) #95287

Merged

ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 24, 2021

adding kibana filter expression functions (elastic#94069)

417f21f

ppisljar added a commit that referenced this pull request Mar 24, 2021

adding kibana filter expression functions (#94069) (#95287)

ecd8871

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding kibana filter expression functions #94069

adding kibana filter expression functions #94069

ppisljar commented Mar 9, 2021 •

edited

Loading

elasticmachine commented Mar 9, 2021

kibanamachine commented Mar 17, 2021

streamich left a comment

streamich Mar 23, 2021 •

edited

Loading

streamich Mar 23, 2021 •

edited

Loading

stratoula left a comment

dokmic left a comment

kibanamachine commented Mar 23, 2021

	const actual = fn(null, { field: { spec: { name: 'test' } } }, context);
	const context = setup();
	const actual = fn(null, { field: { spec: { name: 'test' } } }, context);

adding kibana filter expression functions #94069

adding kibana filter expression functions #94069

Conversation

ppisljar commented Mar 9, 2021 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Mar 9, 2021

kibanamachine commented Mar 17, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

streamich left a comment

Choose a reason for hiding this comment

streamich Mar 23, 2021 • edited Loading

Choose a reason for hiding this comment

streamich Mar 23, 2021 • edited Loading

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

dokmic left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 23, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

ppisljar commented Mar 9, 2021 •

edited

Loading

streamich Mar 23, 2021 •

edited

Loading

streamich Mar 23, 2021 •

edited

Loading