-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Case] Push ITSM comments as work notes #93916
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/security_solution/users·ts.apis SecuritySolution Endpoints Users With auditbeat Ensure data is returned from auditbeatStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/security_solution/users·ts.apis SecuritySolution Endpoints Users With auditbeat "after all" hook for "Ensure data is returned from auditbeat"Standard Out
Stack Trace
Metrics [docs]
To update your PR or re-run it, just comment with: cc @cnasikas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerting changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. manual testing works as expected for SN ITSM and SecOps. LGTM
…3916) * Push ITSM comments as work notes * Fix cases mapping * Improve error messages * Fix tests
Summary
ServiceNow ITSM has two fields for creating comments work notes and comments. Work notes are for internal use and the comments are for public use. Comments in Elastic are the not the same as comments in ServiceNow. This PR fixes this issue and push Cases/Alerts comments as work notes. It also improves the error messaging.
Checklist
Delete any items that are not applicable to this PR.
For maintainers