Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] 7.12 doc updates #93830

Merged
merged 4 commits into from
Mar 6, 2021
Merged

[Maps] 7.12 doc updates #93830

merged 4 commits into from
Mar 6, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 5, 2021

7.12 documentation updates

@nreese nreese added Team:Docs [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Mar 5, 2021
@nreese nreese requested a review from gchaps March 5, 2021 20:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

docs/maps/map-settings.asciidoc Outdated Show resolved Hide resolved
. Enter `Tutorial web logs map` for the title.
. Ensure *Add to Dashboard after saving* is enabled.
. Click *Save and return*.
. In the toolbar, click *Save and return*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is only 1 step in this section, how about just including that step at the end of the previous section:

  1. To save the map and return to the dashboard, click Save and return.

Is it "Save and return" or "Save & return"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about burying this step at the end of the last section. Its a crucial step that is really separate from the previous step. How do you feel about keeping it as a separate section for visibility, even though its so short?

docs/maps/vector-style-properties.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style-properties.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style-properties.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style-properties.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style-properties.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style-properties.asciidoc Outdated Show resolved Hide resolved
@nreese nreese requested a review from gchaps March 5, 2021 23:37
@nreese nreese merged commit a1ac49a into elastic:master Mar 6, 2021
nreese added a commit to nreese/kibana that referenced this pull request Mar 6, 2021
* [Maps] 712 doc updates

* Update docs/maps/vector-style-properties.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* avoid wrapping property name column in table

Co-authored-by: gchaps <[email protected]>
nreese added a commit to nreese/kibana that referenced this pull request Mar 6, 2021
* [Maps] 712 doc updates

* Update docs/maps/vector-style-properties.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* avoid wrapping property name column in table

Co-authored-by: gchaps <[email protected]>
nreese added a commit that referenced this pull request Mar 6, 2021
* [Maps] 712 doc updates

* Update docs/maps/vector-style-properties.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* avoid wrapping property name column in table

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
nreese added a commit that referenced this pull request Mar 6, 2021
* [Maps] 712 doc updates

* Update docs/maps/vector-style-properties.asciidoc

Co-authored-by: gchaps <[email protected]>

* review feedback

* avoid wrapping property name column in table

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants