Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Field formats] Fix switching away from duration formatter #93818

Merged
merged 6 commits into from
Mar 10, 2021
Merged

[Field formats] Fix switching away from duration formatter #93818

merged 6 commits into from
Mar 10, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Mar 5, 2021 •
edited
Loading

Summary

Fixes switching between duration and another formatter by simplifying the format editor rendering process. Added functional test to verify this doesn't break again.

closes #93349

@mattkime mattkime changed the title simplify field format editor rendering [Field formats] Fix switching away from duration formatter Mar 10, 2021
@mattkime mattkime marked this pull request as ready for review March 10, 2021 05:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Dosant
Dosant approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I reproduced the issue in master and verified that it isn't reproduced in the branch. Nice cleanup 👍

p.s. Is there an existing issue this pr closes? I think I saw one about this, but couldn't find it

test/functional/apps/management/_field_formatter.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexPatternFieldEditor 82.9KB 82.6KB -378.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 44d8093 into elastic:master Mar 10, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 93818 or prevent reminders by adding the backport:skip label.

mattkime added a commit to mattkime/kibana that referenced this pull request Mar 15, 2021
@mattkime
[Field formats] Fix switching away from duration formatter (elastic#9…
5aa661e 
…3818)

* simplify field format editor rendering, fixes switching away from duration formatter
@mattkime mattkime mentioned this pull request Mar 15, 2021
Merged
mattkime added a commit that referenced this pull request Mar 15, 2021
@mattkime
[Field formats] Fix switching away from duration formatter (#93818) (#…
3ed0a00 
…94631)

* simplify field format editor rendering, fixes switching away from duration formatter
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
Feature:FieldFormatters release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Field formats] Field format editor crashes when switching away from duration formatter
4 participants
@mattkime @elasticmachine @kibanamachine @Dosant