-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Add nested field inside of data provider #93721
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
71a6ea2
to
50695bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not do a code review, but rather reviewed behavior.
-
Generated enriched alerts via these steps:
-
Send e.g.
matched.atomic
to the timeline, and observe that timeline is now filtered to only those events:
-
Move the non-overlapping field to AND and see results drop to 0:
So far so good; the one thing that did not work was sending a nested date field to timeline; it seems not to generate any filter at all:
So: one minor bug with date fields, hopefully; otherwise things look great!
Approving as nested date fields appears to be a separate issue, and this PR still improves current behavior. |
@XavierM @kqualters-elastic I'm not seeing an issue with dates in Discover with the mapped |
1866299
to
1a63ea9
Compare
1a63ea9
to
1ad9be5
Compare
Just pulled down the latest (1ad9be5) and confirmed that the date bug has been fixed: The above screenshot demonstrates that the date filtering works in conjunction with a normal filter; previously the number of events returned was in the thousands. Moving either filter to an OR also correctly expands the number of results. LGTM |
@elasticmachine merge upstream |
…#93721) * add nested field inside of dataprovider * make sure to get nested * fix elq server side * add mock for nested attributes * Add basic tests for nested fields query generation * Update snapshots and failing tests with nestedFields * fix nested date Co-authored-by: Kevin Qualters <[email protected]>
…#93721) * add nested field inside of dataprovider * make sure to get nested * fix elq server side * add mock for nested attributes * Add basic tests for nested fields query generation * Update snapshots and failing tests with nestedFields * fix nested date Co-authored-by: Kevin Qualters <[email protected]>
…#94121) * add nested field inside of dataprovider * make sure to get nested * fix elq server side * add mock for nested attributes * Add basic tests for nested fields query generation * Update snapshots and failing tests with nestedFields * fix nested date Co-authored-by: Kevin Qualters <[email protected]> Co-authored-by: Kevin Qualters <[email protected]>
…#94080) * add nested field inside of dataprovider * make sure to get nested * fix elq server side * add mock for nested attributes * Add basic tests for nested fields query generation * Update snapshots and failing tests with nestedFields * fix nested date Co-authored-by: Kevin Qualters <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Kevin Qualters <[email protected]> Co-authored-by: MadameSheema <[email protected]>
Summary
This PR is to fix #89784, we will be able to drag/add nested query inside of the data provider.
To validate this PR id created this index like below and was able to drag and drop this field inside of the data provider
Checklist