Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Styling for histogram #93663

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[Security Solution] Styling for histogram #93663

merged 1 commit into from
Mar 4, 2021

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Mar 4, 2021

Summary

This PR is to fix #82421
The data displayed on some histogram axis of hosts pages is overlaid

Steps to Verify:

  1. Navigate to hosts pages
  2. Set the timerange to 2020-Nov-02 15:00 to 2020-Dec-31 9:00
  3. Check if the axis ticks display properly without overlaid.

Before:
https://user-images.githubusercontent.com/17427073/97988808-d563d680-1ddd-11eb-9bcf-ff69877fd782.png

After:
Screenshot 2021-03-05 at 02 50 54

@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 4, 2021
@angorayc angorayc requested a review from a team as a code owner March 4, 2021 18:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +31.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

andrew-goldstein
andrew-goldstein approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @angorayc! 🙏

Desk tested locally in:

  • Chrome 89.0.4389.72
  • Firefox 86.0
  • Safari 14.0.3

LGTM

@angorayc angorayc merged commit 7c9e08e into elastic:master Mar 4, 2021
@angorayc angorayc mentioned this pull request Mar 4, 2021
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Mar 4, 2021
@angorayc
styling (elastic#93663)
912e822
angorayc added a commit to angorayc/kibana that referenced this pull request Mar 4, 2021
@angorayc
styling (elastic#93663)
124a7f2
@angorayc angorayc mentioned this pull request Mar 4, 2021
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
822d988 
* master:
  styling (elastic#93663)
angorayc added a commit that referenced this pull request Mar 5, 2021
@angorayc
styling (#93663) (#93708)
ca38a31
angorayc added a commit that referenced this pull request Mar 5, 2021
@angorayc @kibanamachine
styling (#93663) (#93707)
7c3d028 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] The data displayed on some histogram axis of hosts pages is overlaid
4 participants
@angorayc @elasticmachine @kibanamachine @andrew-goldstein