Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12] Make tests deterministic by providing unique timestamps (#93350) #93472

Closed
wants to merge 1 commit into from

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Mar 3, 2021

Backports the following commits to 7.12:

The threat intel data that we are loading for these tests was previously
copy/pasted, resulting in all docs having the same @timestamp value.
This resulted in nondeterministic ordering which manifested as test
failures.

This fixes the issue by giving a unique timestamp to each indicator
document, and then unskips/updates tests according to this new ordering.
@rylnd rylnd added the backport label Mar 3, 2021
@rylnd rylnd enabled auto-merge (squash) March 3, 2021 17:57
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd disabled auto-merge March 3, 2021 19:38
@rylnd
Copy link
Contributor Author

rylnd commented Mar 3, 2021

Closing this backport as the original PR did not fix the issue.

@rylnd rylnd closed this Mar 3, 2021
@rylnd rylnd deleted the backport/7.12/pr-93350 branch March 3, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants