Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix alert instance key for single metric jobs #93442

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[ML] Fix alert instance key for single metric jobs #93442

merged 1 commit into from
Mar 3, 2021

Conversation

darnautov
Copy link
Contributor

Summary

This PR fixes alert instance ids generation for anomaly records without by, over, or partition field.
Hence for single metric jobs myJobId_timestamp_1_sum_undefined_undefined key becomes myJobId_timestamp_1_sum.

@darnautov darnautov added bug Fixes for quality problems that affect the customer experience :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Mar 3, 2021
@darnautov darnautov self-assigned this Mar 3, 2021
@darnautov darnautov requested a review from a team as a code owner March 3, 2021 15:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@darnautov darnautov enabled auto-merge (squash) March 3, 2021 15:48
@darnautov darnautov added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit a8d45e7 into elastic:master Mar 3, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2021
@darnautov @kibanamachine
[ML] fix alert instance key for the single metric job (elastic#93442)
4a544a6
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2021
@darnautov @kibanamachine
[ML] fix alert instance key for the single metric job (elastic#93442)
e7e93ca
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #93467
✅ 7.x / #93468

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 3, 2021
@kibanamachine @darnautov
[ML] fix alert instance key for the single metric job (#93442) (#93467)
ad75625 
Co-authored-by: Dima Arnautov <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 3, 2021
@kibanamachine @darnautov
[ML] fix alert instance key for the single metric job (#93442) (#93468)
cf28bfb 
Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson