-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add log min limit option to value axis options #93352
Conversation
Waiting on elastic/elastic-charts#1057 |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.src/plugins/vis_type_xy/public/editor/components/options/metrics_axes.ValueAxesPanel component should init with the default set of propsStandard Out
Stack Trace
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it locally and I've to admit that this is a bit too complicated to understand for me.
In particular, I can't understand exactly what is the difference between setting the domain extent to 0.01
or the log min limit to 0.01
what is the actual difference?
The difference is that the log limit is more of a soft limit and the extent is a hard limit. The log limit excludes values that are smaller than the given value. I agree it is not the most obvious but I don't know how else to explain it. |
Apologies for the delay on this @th0ger. We couldn't find a good way to implement this with adding a new parameter to the vis editor. I opened a new issue in charts repo to set this min log limit automatically instead of hardcoding it to |
Summary
fixes #83917
Add option to
Y-Axes
config in visualize xy charts to set a log min limit to contain log data using an explicit limit and not the kibana implicit limit of1
.This option is only available when an axes config is linked to one or more non-stacked line series. This is to discourage bad practices for area charts and stacked lines.
Note: When
Set log min limit
is disabled, the implied value of1
will be used.Screen.Recording.2021-04-06.at.06.12.40.PM.mp4
Checklist
For maintainers