Fixes parent pipeline aggregations with custom metric and custom sort order #93276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
review
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
streamich
approved these changes
Mar 3, 2021
|
@elasticmachine merge upstream |
ppisljar
force-pushed
the
fix/aggConfigSubAggs
branch
from
f55fbd7 to
557d9e0
Compare
ppisljar
added
the
auto-backport
💔 Backport failed❌ 7.12: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
|
@ppisljar the PR title here doesn't really fit our release note style. It doesn't tell a user what was fixed. Also, I think you need to include the 7.13.0 tag for backporting |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 4, 2021
…into actions/terminology-api * 'actions/terminology-api' of github.com:gmmorris/kibana: Make Dashboard Unsaved Changes Space Specific (elastic#92680) Hide Value and Funtional boost for geolocation (elastic#93683) [Fleet] Set all keyword and text fields for `index.query.default_field` index template setting (elastic#91791) can not query the world (elastic#93556) [Security Solutions] Sets our default date time to be "today" instead of "Last 24 hours" to enable cachability and fixes one date math bug in the URL (elastic#93548) [Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note (elastic#93306) fix agg config sub agg dsl generation (elastic#93276)
ppisljar
changed the title
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Mar 5, 2021
# Conflicts: # api_docs/data.json # api_docs/data_search.json
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
ppisljar
added a commit
that referenced
this pull request
Mar 5, 2021
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Mar 5, 2021
# Conflicts: # api_docs/data.json # api_docs/data_search.json
ppisljar
added a commit
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent pipeline aggregations with custom metric and custom sort order on the bucket work again in visualize.
Resolves #87511
For maintainers