Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY Charts] fix partial histogram endzones annotations #93091

Merged
merged 8 commits into from
Mar 4, 2021
Merged

[XY Charts] fix partial histogram endzones annotations #93091

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d4f948
fix endzones in xy charts
nickofthyme Mar 1, 2021
52b7290
manually enable time filter for date histograms
nickofthyme Mar 2, 2021
32dc89c
remove disable method
nickofthyme Mar 2, 2021
12f6752
fix bounds to use xaggs bounds not from timefilter
nickofthyme Mar 2, 2021
04f0770
Merge branch 'master' into fix-endzones
nickofthyme Mar 3, 2021
9381a7b
fix failing functional test
nickofthyme Mar 3, 2021
542b2ca
fix failing functional tests
nickofthyme Mar 3, 2021
5b2fbae
Merge branch 'master' into fix-endzones
kibanamachine Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/vis_type_xy/public/utils/domain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const getXDomain = (params: Aspect['params']): DomainRange => {
const minInterval = (params as DateHistogramParams | HistogramParams)?.interval ?? undefined;

if ((params as DateHistogramParams).date) {
const bounds = getTimefilter().getActiveBounds();
const bounds = getTimefilter().getBounds();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickofthyme that was changed to use getActiveBounds due to the following:
#89822 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so any idea why this would return undefined when a time range is active?

Copy link
Contributor Author

@nickofthyme nickofthyme Mar 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I manually enabled the time filter for date histogram charts. I'm not sure why this is not already happening automatically. But I see timelion is doing this and I modeled the renderer changes after timelion. See https://github.com/elastic/kibana/pull/93091/files

Ok I reverted the code to use xAgg.buckets.getBounds which knows about the enablement of the time filter and is how vislib handles getting the time bounds. Both the time-based and non-time-based data seem to be working fine.


if (bounds) {
return {
Expand Down