[App Search] Add delete action to EnginesTable component #92844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronhulcher
added
auto-backport
byronhulcher
force-pushed
the
delete-engine-action
branch
from
df98336 to
69de7f9
Compare
byronhulcher
force-pushed
the
delete-engine-action
branch
from
69de7f9 to
097d26a
Compare
byronhulcher
commented
Feb 25, 2021
...ins/enterprise_search/public/applications/app_search/components/engines/engines_overview.tsx
Show resolved
Hide resolved
JasonStoltz
requested changes
Feb 26, 2021
x-pack/plugins/enterprise_search/server/routes/app_search/engines.test.ts
Show resolved
Hide resolved
...plugins/enterprise_search/public/applications/app_search/components/engines/engines_logic.ts
Outdated
Show resolved
Hide resolved
...ns/enterprise_search/public/applications/app_search/components/engines/engines_logic.test.ts
Outdated
Show resolved
Hide resolved
...lugins/enterprise_search/public/applications/app_search/components/engines/engines_table.tsx
Outdated
Show resolved
Hide resolved
...s/enterprise_search/public/applications/app_search/components/engines/engines_table.test.tsx
Outdated
Show resolved
Hide resolved
...s/enterprise_search/public/applications/app_search/components/engines/engines_table.test.tsx
Show resolved
Hide resolved
...s/enterprise_search/public/applications/app_search/components/engines/engines_table.test.tsx
Outdated
Show resolved
Hide resolved
...s/enterprise_search/public/applications/app_search/components/engines/engines_table.test.tsx
Outdated
Show resolved
Hide resolved
...s/enterprise_search/public/applications/app_search/components/engines/engines_table.test.tsx
Show resolved
Hide resolved
...s/enterprise_search/public/applications/app_search/components/engines/engines_table.test.tsx
Outdated
Show resolved
Hide resolved
byronhulcher
force-pushed
the
delete-engine-action
branch
from
0055ebc to
b6c66d0
Compare
JasonStoltz
approved these changes
Mar 2, 2021
|
Hey @JasonStoltz as a heads up, I updated the logic in |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 9, 2021
* Add delete engine route to App Search * Add new deleteEngine listener to EnginesLogic * Convert EnginesTable Manage into a proper EuiBasicTable action * Call EnginesLogic.actions.deleteEngine using new action in EnginesTable * Manage action on EnginesTable should use eye icon * Confirmation alert for delete action on EnginesTable * Only display manage/delete actions to users with canManageEngines * Add success message and reload after successful engine delete * Jest tests for EngineTable actions * Copy change for engine delete success message * Fixing EnginesTable tests * Adding more tests for DELETE engine route * engineNameLink -> EngineNameLink * Remove redundant test * Convert Engine.type to enum EngineTypes * Must use mountWithIntl * Use platinum license instead of role ability check
kibanamachine
added a commit
that referenced
this pull request
Mar 9, 2021
…4099) * Add delete engine route to App Search * Add new deleteEngine listener to EnginesLogic * Convert EnginesTable Manage into a proper EuiBasicTable action * Call EnginesLogic.actions.deleteEngine using new action in EnginesTable * Manage action on EnginesTable should use eye icon * Confirmation alert for delete action on EnginesTable * Only display manage/delete actions to users with canManageEngines * Add success message and reload after successful engine delete * Jest tests for EngineTable actions * Copy change for engine delete success message * Fixing EnginesTable tests * Adding more tests for DELETE engine route * engineNameLink -> EngineNameLink * Remove redundant test * Convert Engine.type to enum EngineTypes * Must use mountWithIntl * Use platinum license instead of role ability check Co-authored-by: Byron Hulcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new action to the
EnginesTablecomponent to delete engines from inside Kibana! Also moves the existing "Manage" action to an icon as per a convo @constancecchen and @daveyholler had (see original issue)Screenshots
EngineTable: Now with actions!
Delete Engine Action: Confirmation pop-up for indexed engines
Delete Engine Action: Success message for indexed engines
Delete Engine Action: Confirmation pop-up for meta engines
Delete Engine Action: Success message for meta engines
Checklist
Delete any items that are not applicable to this PR.