-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix bug in Safari and Firefox form rendering #92542
[Lens] Fix bug in Safari and Firefox form rendering #92542
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
</EuiPanel> | ||
</section> | ||
|
||
<DimensionContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: the basic change is to extract this DimensionContainer
component out of its previous location inside the section
that we track by reference. I made this change by inspecting the EUI focus/blur events and noticing that they had a lot of shared parents, and that this was not needed in my local test case with EUI forms.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Chrome, Safari and Firefox and popovers close fine now, LGTM
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_details·ts.endpoint When on the Endpoint Policy Details Page and the save button is clicked should have cleared the advanced section when the user deletes the valueStandard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Fixes #92182
Checklist
Not sure how to test this except manually