-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] adds Connectors APIs and deprecates old Actions APIs as per the new Alerting terminology #92451
Merged
Merged
[Alerting] adds Connectors APIs and deprecates old Actions APIs as per the new Alerting terminology #92451
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
47594cb
moved legacy actions api to legacy folder
gmmorris e4cac15
introduced connector create api
gmmorris 14e9f1f
added new delete route
gmmorris 4ec8d3a
added new execute and get_all
gmmorris 1caa038
introduced all connector APIs
gmmorris abf36db
renamed action to connector in Apis
gmmorris a1ab01d
comment on camel case type
gmmorris 234cdfc
fixed va
gmmorris 88098e3
Merge branch 'master' into actions/terminology-api
gmmorris c7f9b0d
updated docs
gmmorris 098b766
legacy title
gmmorris f71f42f
corrected APIs
gmmorris 6f2333d
legacy links
gmmorris 020385a
added linik to deprecatred APIs
gmmorris bb283bf
added linik to deprecatred APIs from index
gmmorris c750557
moved legacy apis down one level
gmmorris d005de3
Apply suggestions from code review
gmmorris 97e2549
renamed route file for connectorTypesRoute
gmmorris 71c8965
Merge branch 'actions/terminology-api' of github.com:gmmorris/kibana …
gmmorris 923cd1e
define legacy route
gmmorris 62a21e9
Update docs/api/actions-and-connectors/legacy/index.asciidoc
gmmorris 55ff443
Merge branch 'master' into actions/terminology-api
gmmorris 3a87a7d
Merge branch 'actions/terminology-api' of github.com:gmmorris/kibana …
gmmorris 4b20afb
Merge branch 'master' into actions/terminology-api
kibanamachine 3deed12
api docs
gmmorris c9d7e0e
Merge branch 'actions/terminology-api' of github.com:gmmorris/kibana …
gmmorris 822d988
Merge branch 'master' into actions/terminology-api
gmmorris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meta comment: I wonder if this is time to remove "Actions and Connectors" confusion. Since they are the same, we could call them "Connectors"? ex: "Manage Connectors" (+folder / file names).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they the same though?
We'll still use action to refer to the execution of something by using a connector, right?
Especially one we support multiple actions per connector...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct but we only have the concept of actions on the side of the alert now, no?
I asked myself: "Is there any docs in the actions and connectors page the user can read to learn more about actions?"