[Search Sessions] Client side search cache

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchinterceptor.getserializableoptions.md

@@ -0,0 +1,22 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [SearchInterceptor](./kibana-plugin-plugins-data-public.searchinterceptor.md) &gt; [getSerializableOptions](./kibana-plugin-plugins-data-public.searchinterceptor.getserializableoptions.md)
+
+## SearchInterceptor.getSerializableOptions() method
+
+<b>Signature:</b>
+
+```typescript
+protected getSerializableOptions(options?: ISearchOptions): Pick<ISearchOptions, "strategy" | "sessionId" | "isStored" | "isRestore" | "legacyHitsTotal">;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  options | <code>ISearchOptions</code> |  |
+
+<b>Returns:</b>
+
+`Pick<ISearchOptions, "strategy" | "sessionId" | "isStored" | "isRestore" | "legacyHitsTotal">`
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchinterceptor.md

@@ -26,6 +26,7 @@ export declare class SearchInterceptor
 
 |  Method | Modifiers | Description |
 |  --- | --- | --- |
+|  [getSerializableOptions(options)](./kibana-plugin-plugins-data-public.searchinterceptor.getserializableoptions.md) |  |  |
 |  [getTimeoutMode()](./kibana-plugin-plugins-data-public.searchinterceptor.gettimeoutmode.md) |  |  |
 |  [handleSearchError(e, options, isTimeout)](./kibana-plugin-plugins-data-public.searchinterceptor.handlesearcherror.md) |  |  |
 |  [search(request, options)](./kibana-plugin-plugins-data-public.searchinterceptor.search.md) |  | Searches using the given <code>search</code> method. Overrides the <code>AbortSignal</code> with one that will abort either when the request times out, or when the original <code>AbortSignal</code> is aborted. Updates <code>pendingCount$</code> when the request is started/finalized. |

src/plugins/data/common/search/tabify/tabify.ts

@@ -139,7 +139,7 @@ export function tabifyAggResponse(
   const write = new TabbedAggResponseWriter(aggConfigs, respOpts || {});
   const topLevelBucket: AggResponseBucket = {
     ...esResponse.aggregations,
-    doc_count: esResponse.hits.total,
+    doc_count: esResponse.hits?.total,
   };
 
   collectBucket(aggConfigs, write, topLevelBucket, '', 1);

src/plugins/data/public/public.api.md

@@ -2354,6 +2354,8 @@ export class SearchInterceptor {
     // (undocumented)
     protected readonly deps: SearchInterceptorDeps;
     // (undocumented)
+    protected getSerializableOptions(options?: ISearchOptions): Pick<ISearchOptions, "strategy" | "sessionId" | "isStored" | "isRestore" | "legacyHitsTotal">;
+    // (undocumented)
     protected getTimeoutMode(): TimeoutErrorMode;
     // Warning: (ae-forgotten-export) The symbol "KibanaServerError" needs to be exported by the entry point index.d.ts
     // Warning: (ae-forgotten-export) The symbol "AbortError" needs to be exported by the entry point index.d.ts

src/plugins/data/public/search/search_interceptor.ts

@@ -113,20 +113,14 @@ export class SearchInterceptor {
     }
   }
 
-  /**
-   * @internal
-   * @throws `AbortError` | `ErrorLike`
-   */
-  protected runSearch(
-    request: IKibanaSearchRequest,
-    options?: ISearchOptions
-  ): Promise<IKibanaSearchResponse> {
-    const { abortSignal, sessionId, ...requestOptions } = options || {};
+  protected getSerializableOptions(options?: ISearchOptions) {
+    const { sessionId, ...requestOptions } = options || {};
+
+    const serializableOptions: ISearchOptionsSerializable = {};
     const combined = {
       ...requestOptions,
       ...this.deps.session.getSearchOptions(sessionId),
     };
-    const serializableOptions: ISearchOptionsSerializable = {};
 
     if (combined.sessionId !== undefined) serializableOptions.sessionId = combined.sessionId;
     if (combined.isRestore !== undefined) serializableOptions.isRestore = combined.isRestore;
@@ -135,10 +129,22 @@ export class SearchInterceptor {
     if (combined.strategy !== undefined) serializableOptions.strategy = combined.strategy;
     if (combined.isStored !== undefined) serializableOptions.isStored = combined.isStored;
 
+    return serializableOptions;
+  }
+
+  /**
+   * @internal
+   * @throws `AbortError` | `ErrorLike`
+   */
+  protected runSearch(
+    request: IKibanaSearchRequest,
+    options?: ISearchOptions
+  ): Promise<IKibanaSearchResponse> {
+    const { abortSignal } = options || {};
     return this.batchedFetch(
       {
         request,
-        options: serializableOptions,
+        options: this.getSerializableOptions(options),
       },
       abortSignal
     );

src/plugins/data/public/search/session/session_service.ts

@@ -73,7 +73,7 @@ export interface SearchSessionIndicatorUiConfig {
 }
 
 /**
- * Responsible for tracking a current search session. Supports only a single session at a time.
+ * Responsible for tracking a current search session. Supports a single session at a time.
  */
 export class SessionService {
   public readonly state$: Observable<SearchSessionState>;

x-pack/plugins/data_enhanced/public/search/search_abort_controller.test.ts

@@ -21,21 +21,24 @@ describe('search abort controller', () => {
   test('immediately aborts when passed an aborted signal in the constructor', () => {
     const controller = new AbortController();
     controller.abort();
-    const sac = new SearchAbortController(controller.signal);
+    const sac = new SearchAbortController();
+    sac.addAbortSignal(controller.signal);
     expect(sac.getSignal().aborted).toBe(true);
   });
 
   test('aborts when input signal is aborted', () => {
     const controller = new AbortController();
-    const sac = new SearchAbortController(controller.signal);
+    const sac = new SearchAbortController();
+    sac.addAbortSignal(controller.signal);
     expect(sac.getSignal().aborted).toBe(false);
     controller.abort();
     expect(sac.getSignal().aborted).toBe(true);
   });
 
   test('aborts when all input signals are aborted', () => {
     const controller = new AbortController();
-    const sac = new SearchAbortController(controller.signal);
+    const sac = new SearchAbortController();
+    sac.addAbortSignal(controller.signal);
 
     const controller2 = new AbortController();
     sac.addAbortSignal(controller2.signal);
@@ -48,7 +51,8 @@ describe('search abort controller', () => {
 
   test('aborts explicitly even if all inputs are not aborted', () => {
     const controller = new AbortController();
-    const sac = new SearchAbortController(controller.signal);
+    const sac = new SearchAbortController();
+    sac.addAbortSignal(controller.signal);
 
     const controller2 = new AbortController();
     sac.addAbortSignal(controller2.signal);
@@ -60,7 +64,8 @@ describe('search abort controller', () => {
 
   test('doesnt abort, if cleared', () => {
     const controller = new AbortController();
-    const sac = new SearchAbortController(controller.signal);
+    const sac = new SearchAbortController();
+    sac.addAbortSignal(controller.signal);
     expect(sac.getSignal().aborted).toBe(false);
     sac.cleanup();
     controller.abort();
@@ -77,15 +82,15 @@ describe('search abort controller', () => {
     });
 
     test('doesnt abort on timeout, if cleared', () => {
-      const sac = new SearchAbortController(undefined, 100);
+      const sac = new SearchAbortController(100);
       expect(sac.getSignal().aborted).toBe(false);
       sac.cleanup();
       timeTravel(100);
       expect(sac.getSignal().aborted).toBe(false);
     });
 
     test('aborts on timeout, even if no signals passed in', () => {
-      const sac = new SearchAbortController(undefined, 100);
+      const sac = new SearchAbortController(100);
       expect(sac.getSignal().aborted).toBe(false);
       timeTravel(100);
       expect(sac.getSignal().aborted).toBe(true);
@@ -94,7 +99,8 @@ describe('search abort controller', () => {
 
     test('aborts on timeout, even if there are unaborted signals', () => {
       const controller = new AbortController();
-      const sac = new SearchAbortController(controller.signal, 100);
+      const sac = new SearchAbortController(100);
+      sac.addAbortSignal(controller.signal);
 
       expect(sac.getSignal().aborted).toBe(false);
       timeTravel(100);

x-pack/plugins/data_enhanced/public/search/search_abort_controller.ts

@@ -18,11 +18,7 @@ export class SearchAbortController {
   private destroyed = false;
   private reason?: AbortReason;
 
-  constructor(abortSignal?: AbortSignal, timeout?: number) {
-    if (abortSignal) {
-      this.addAbortSignal(abortSignal);
-    }
-
+  constructor(timeout?: number) {
     if (timeout) {
       this.timeoutSub = timer(timeout).subscribe(() => {
         this.reason = AbortReason.Timeout;
@@ -41,6 +37,7 @@ export class SearchAbortController {
   };
 
   public cleanup() {
+    if (this.destroyed) return;
     this.destroyed = true;
     this.timeoutSub?.unsubscribe();
     this.inputAbortSignals.forEach((abortSignal) => {