Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show event context #9198

Merged
merged 118 commits into from
Feb 22, 2017
Merged
Changes from 1 commit
Commits
Show all changes
118 commits
Select commit Hold shift + click to select a range
f80a169
Add app to display discover entry context
weltenwort Nov 18, 2016
05aedd8
Extract multi-transclude workaround into directive
weltenwort Nov 21, 2016
2e422f7
Add a generic local-navigation directive
weltenwort Nov 21, 2016
89b31e9
Use `<local-navigation>` for context size controls
weltenwort Nov 21, 2016
3227016
Wire up the context app state to the url
weltenwort Nov 21, 2016
ef78a3c
Add basic link from discover to the context app
weltenwort Nov 21, 2016
be355d8
Change context view breadcrumbs
weltenwort Nov 22, 2016
b2db703
Return promises from the reload and init actions
weltenwort Nov 22, 2016
c3d7459
Make the context size display editable
weltenwort Nov 22, 2016
9e5986c
Always sort on the index-pattern's time field
weltenwort Nov 23, 2016
d64f938
Improve doc and context link styling in docTable
weltenwort Nov 23, 2016
2acc123
Fix font-awesome class name typo
weltenwort Nov 23, 2016
4991bd8
Hide context link for non-time-based index patterns
weltenwort Nov 23, 2016
1bb189d
Merge branch 'master' into discover-context-app
weltenwort Dec 5, 2016
e10f458
Add setting to configure the default context size
weltenwort Dec 5, 2016
123d6b0
Add setting to configure the context size step
weltenwort Dec 5, 2016
dbaed4f
Enforce a minimal context size of 0
weltenwort Dec 5, 2016
840278f
Reimplement the local nav without multi-transclusion
weltenwort Dec 6, 2016
4730c77
Add visual indicator for first initialization
weltenwort Dec 6, 2016
2054287
Merge commit '10f7880' into discover-context-app
weltenwort Dec 13, 2016
a9c96aa
Improve loading ui and behaviour, refactor state
weltenwort Dec 13, 2016
a2b1456
Merge branch 'master' into discover-context-app
weltenwort Dec 13, 2016
bb1b056
Remove plus icons from "load more" buttons
weltenwort Dec 13, 2016
36c9b17
Merge branch 'master' into discover-context-app
weltenwort Dec 13, 2016
72e7faf
Merge branch 'master' into discover-context-app
weltenwort Dec 14, 2016
366962a
Fix AppState synchronization
weltenwort Dec 15, 2016
a98d967
Merge branch 'master' into discover-context-app
weltenwort Dec 15, 2016
778d3ce
Fix linting errors
weltenwort Dec 15, 2016
46d8472
Fix more linting errors
weltenwort Dec 15, 2016
3ae8a5d
Make anchor highlighting more prominent
weltenwort Dec 16, 2016
ddda2ff
Remove obsolete isInitialized from state
weltenwort Dec 16, 2016
84d0a3d
Replace history entry when persisting state
weltenwort Dec 16, 2016
491e212
Merge branch 'master' into discover-context-app
weltenwort Dec 16, 2016
89f3af2
Update to new kui css classes
weltenwort Dec 16, 2016
170b6e6
Merge branch 'master' into discover-context-app
weltenwort Dec 19, 2016
cfd0573
Change the design of the "load more" buttons
weltenwort Dec 19, 2016
3ed6941
Stop abusing the kuiLocalMenu styles for sizePicker
weltenwort Dec 19, 2016
d15b35c
Fix imports of removed style file
weltenwort Dec 19, 2016
c2d2240
Use more popular redux terminology
weltenwort Dec 20, 2016
ed354e0
Split state management into separate files
weltenwort Dec 20, 2016
62f7342
Add helpers to bind selectors to state
weltenwort Dec 20, 2016
5472730
Factor out the size picker into a separate directive
weltenwort Dec 20, 2016
b7a789d
Make "load more" buttons full-width
weltenwort Dec 20, 2016
34abd9c
Merge branch 'master' into discover-context-app
weltenwort Jan 2, 2017
e9cdb7a
Use tabs in the LocalNav
weltenwort Jan 2, 2017
00d1bbe
Use yellow outline for anchor highlighting
weltenwort Jan 2, 2017
d3a37cb
Use kui classes for links in discover detail links
weltenwort Jan 2, 2017
d4daca4
Merge branch 'master' into discover-context-app
weltenwort Jan 5, 2017
6ac96e2
Merge branch 'master' into discover-context-app
weltenwort Jan 6, 2017
2cbbf62
Add implementation notes
weltenwort Jan 6, 2017
ce2d015
Remove superfluous directives
weltenwort Jan 6, 2017
a7d32ac
Factor out loading button component
weltenwort Jan 6, 2017
fbb61c1
Add directory structure to notes
weltenwort Jan 6, 2017
82f88c4
Add unit tests
weltenwort Jan 10, 2017
2f31979
Use chai instead of expect.js in tests
weltenwort Jan 11, 2017
5cc91aa
Add more unit tests
weltenwort Jan 11, 2017
b80be8b
Merge branch 'master' into discover-context-app
weltenwort Jan 11, 2017
02440e8
Remove redux concepts in response to code review
weltenwort Jan 12, 2017
cb4d95f
Improve Context Log highlighting and UI. (#1)
cjcenizal Jan 12, 2017
2e5b192
Add missing successor loading status
weltenwort Jan 12, 2017
5c50c1d
Factor out initial queryParameters state creation
weltenwort Jan 16, 2017
43472f5
Add basic acceptance tests (WIP)
weltenwort Jan 17, 2017
5272a76
Add some context size tests
weltenwort Jan 18, 2017
2756db1
Remove selectors in reaction to review feedback
weltenwort Jan 18, 2017
de6983f
Bind SizePickerController to a proper name
weltenwort Jan 19, 2017
cbe3602
Merge branch 'master' into discover-context-app
weltenwort Jan 20, 2017
29e1fa8
Replace object spread syntax with Object.assign
weltenwort Jan 20, 2017
19df62f
Rename setCount to onChangeCount
weltenwort Jan 20, 2017
9e4dcea
Use Promise.try to catch more errors
weltenwort Jan 20, 2017
e0046e2
Track loading errors and notify the user about them
weltenwort Jan 20, 2017
1b7fb54
Disable size picker inputs until anchor is loaded
weltenwort Jan 20, 2017
cdae37c
Fix ContextPage class name
weltenwort Jan 23, 2017
9d411ea
Explicitly reset the view value in debounced input
weltenwort Jan 24, 2017
826910e
Replace uses of chai with expect.js
weltenwort Jan 25, 2017
0566459
Add docstrings and annotations
weltenwort Jan 25, 2017
4b275b9
Remove the need to separately pass the anchor uid
weltenwort Jan 25, 2017
61d7683
Re-use `KbnUrl` to encode the url components
weltenwort Jan 26, 2017
c0021f2
Preserve previous discover state in breadcrumb url
weltenwort Jan 26, 2017
a916f49
Start to remove duplication from PageObjects
weltenwort Jan 26, 2017
f07926b
Merge branch 'master' into discover-context-app
weltenwort Jan 27, 2017
05cc080
Merge branch 'master' into discover-context-app
weltenwort Jan 31, 2017
ef3573e
Update implementation notes
weltenwort Jan 31, 2017
183991e
Introduce loading status constants, separate state
weltenwort Feb 1, 2017
8997be7
Remove obsolete border work-around
weltenwort Feb 1, 2017
61f0423
Split query and query_parameters files
weltenwort Feb 1, 2017
6af8043
Extract route template into separate html file
weltenwort Feb 1, 2017
d8a7a4f
Replace _.spread with argument spread syntax
weltenwort Feb 2, 2017
a0040cc
Use new kui error info panel
weltenwort Feb 2, 2017
d23f2e4
Inline reversing the results
weltenwort Feb 2, 2017
e8862c7
Add a link to Discover to the error message
weltenwort Feb 2, 2017
0102c18
Rename disabled property of the loading button
weltenwort Feb 2, 2017
9ef0b69
Merge branch 'master' into discover-context-app
weltenwort Feb 3, 2017
9af7cb6
Show end-of-data warnings to the user
weltenwort Feb 3, 2017
f8dcd35
Rename query to queryBody where appropriate
weltenwort Feb 6, 2017
41ea1bf
Remove Discover breadcrumb
weltenwort Feb 6, 2017
0a4fa98
Merge branch 'master' into discover-context-app
weltenwort Feb 8, 2017
a3572d0
Get the config options lazily
weltenwort Feb 8, 2017
ce4c07f
Limit the context size to Elasticsearch's limit
weltenwort Feb 9, 2017
938e841
Increase the size picker width
weltenwort Feb 9, 2017
06245b9
Move the size picker to the left
weltenwort Feb 9, 2017
44c1e8c
Add comment about ngModel getter/setter
weltenwort Feb 10, 2017
519a3a4
Don't disable load-more buttons on failure
weltenwort Feb 10, 2017
3856851
Revert button styling of links in discover
weltenwort Feb 10, 2017
61be5c1
Adjust header content
weltenwort Feb 10, 2017
912df52
Merge branch 'master' into discover-context-app
weltenwort Feb 10, 2017
21c9098
Fix function names in unit tests
weltenwort Feb 10, 2017
c6ac75b
Add test for navigation from Discover to Context View
weltenwort Feb 14, 2017
9706068
Move updating the configuration into before block
weltenwort Feb 14, 2017
9b8bf37
Add query_parameter action tests
weltenwort Feb 14, 2017
8998279
Merge branch 'master' into discover-context-app
weltenwort Feb 15, 2017
ad1c856
Switch loading button and size picker locations
weltenwort Feb 16, 2017
d8f99e7
Rename entries to documents
weltenwort Feb 16, 2017
8a5b60e
Display loading step size on button
weltenwort Feb 16, 2017
50205b8
Merge branch 'master' into discover-context-app
weltenwort Feb 16, 2017
cb2bae6
Fix anchor highlight render bug in chrome
weltenwort Feb 16, 2017
12ce61b
Improve test case wording
weltenwort Feb 21, 2017
2784b0c
Merge branch 'master' into discover-context-app
weltenwort Feb 22, 2017
62bf542
Update notes to match the dir structure
weltenwort Feb 22, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Limit the context size to Elasticsearch's limit
weltenwort committed Feb 9, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ce4c07f5f65db5a5427884ca8ae9cf9e6a5203f9
18 changes: 13 additions & 5 deletions src/core_plugins/kibana/public/context/query_parameters/actions.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
import _ from 'lodash';

import { QUERY_PARAMETER_KEYS } from './constants';
import {
MAX_CONTEXT_SIZE,
MIN_CONTEXT_SIZE,
QUERY_PARAMETER_KEYS,
} from './constants';


const MIN_CONTEXT_SIZE = 0;

export function QueryParameterActionsProvider(config) {
const getDefaultSizeStep = () => parseInt(config.get('context:step'), 10);

const setPredecessorCount = (state) => (predecessorCount) => (
state.queryParameters.predecessorCount = Math.max(
state.queryParameters.predecessorCount = clamp(
MIN_CONTEXT_SIZE,
MAX_CONTEXT_SIZE,
predecessorCount,
)
);
@@ -20,8 +23,9 @@ export function QueryParameterActionsProvider(config) {
);

const setSuccessorCount = (state) => (successorCount) => (
state.queryParameters.successorCount = Math.max(
state.queryParameters.successorCount = clamp(
MIN_CONTEXT_SIZE,
MAX_CONTEXT_SIZE,
successorCount,
)
);
@@ -46,3 +50,7 @@ export function QueryParameterActionsProvider(config) {
setSuccessorCount,
};
}

function clamp(minimum, maximum, value) {
return Math.max(Math.min(maximum, value), minimum);
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { createInitialQueryParametersState } from './state';


export const MAX_CONTEXT_SIZE = 10000; // Elasticsearch's default maximum size limit
export const MIN_CONTEXT_SIZE = 0;
export const QUERY_PARAMETER_KEYS = Object.keys(createInitialQueryParametersState());
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
export { QueryParameterActionsProvider } from './actions';
export { QUERY_PARAMETER_KEYS } from './constants';
export {
MAX_CONTEXT_SIZE,
MIN_CONTEXT_SIZE,
QUERY_PARAMETER_KEYS,
} from './constants';
export { createInitialQueryParametersState } from './state';