Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Bug: Service overview - Sparkline loading state icons has changed #91884

Merged
merged 2 commits into from
Feb 19, 2021
Merged

[APM] Bug: Service overview - Sparkline loading state icons has changed #91884

merged 2 commits into from
Feb 19, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #91806

Screenshot 2021-02-18 at 11 39 36

Screenshot 2021-02-18 at 11 40 57

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 18, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner February 18, 2021 17:21
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

formgeist
formgeist approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Position looks good, I had given you the wrong color variable for the icon so see suggestion.

x-pack/plugins/apm/public/components/shared/charts/spark_plot/index.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB +146.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 99a60ca into elastic:master Feb 19, 2021
@cauemarcondes cauemarcondes deleted the apm-sparkline-loading-icon branch February 19, 2021 16:15
@kibanamachine kibanamachine mentioned this pull request Feb 19, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2021
@cauemarcondes @kibanamachine
[APM] Bug: Service overview - Sparkline loading state icons has chang…
2a0b75c 
…ed (elastic#91884)

* adjusting icon size

* Updating color
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #92038

Successful backport PRs will be merged automatically after passing CI.

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Feb 19, 2021
@cauemarcondes
[APM] Bug: Service overview - Sparkline loading state icons has chang…
464bd8f 
…ed (elastic#91884)

* adjusting icon size

* Updating color
@cauemarcondes cauemarcondes mentioned this pull request Feb 19, 2021
Merged
kibanamachine added a commit that referenced this pull request Feb 19, 2021
@kibanamachine @cauemarcondes
[APM] Bug: Service overview - Sparkline loading state icons has chang…
e66061a 
…ed (#91884) (#92038)

* adjusting icon size

* Updating color

Co-authored-by: Cauê Marcondes <[email protected]>
cauemarcondes added a commit that referenced this pull request Feb 19, 2021
@cauemarcondes
[APM] Bug: Service overview - Sparkline loading state icons has chang…
3d689b9 
…ed (#91884) (#92039)

* adjusting icon size

* Updating color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Bug: Service overview - Sparkline loading state icons has changed
5 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @formgeist