Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Accept core changes #91826

Merged
merged 1 commit into from
Feb 18, 2021
Merged

[DOCS] Accept core changes #91826

merged 1 commit into from
Feb 18, 2021

Conversation

afharo
Copy link
Member

@afharo afharo commented Feb 18, 2021

Summary

It looks like feedback updates to the PR #89915 didn't trigger any API docs errors in the CI (known bug if only amending descriptions). This PR is to push those updates.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes docs v7.12.0 labels Feb 18, 2021
@afharo afharo marked this pull request as ready for review February 18, 2021 12:09
@afharo afharo requested a review from lukeelmers February 18, 2021 12:10
@afharo afharo added auto-backport Deprecated - use backport:version if exact versions are needed v7.13.0 labels Feb 18, 2021
lukeelmers
lukeelmers approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

I didn't know about this bug until these changes popped up in another PR, appreciate you making the update!

@lukeelmers lukeelmers mentioned this pull request Feb 18, 2021
Merged
@afharo afharo merged commit 3c0d73a into elastic:master Feb 18, 2021
@afharo afharo deleted the core-docs/accept-changes branch February 18, 2021 14:35
@kibanamachine kibanamachine mentioned this pull request Feb 18, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2021
@afharo @kibanamachine
[DOCS] Accept core changes (elastic#91826)
3359b6a
@kibanamachine
Copy link
Contributor

💔 Backport failed

✅ 7.x / #91847
❌ 7.13: The branch "7.13" is invalid or doesn't exist

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 91826

kibanamachine added a commit that referenced this pull request Feb 18, 2021
@kibanamachine @afharo
[DOCS] Accept core changes (#91826) (#91847)
20b2e03 
Co-authored-by: Alejandro Fernández Haro <[email protected]>
@afharo afharo removed the v7.13.0 label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afharo @kibanamachine @lukeelmers