Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Show unmapped fields when reading from source #91719

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Feb 17, 2021

Summary

Fixes: #91697

This PR shows unmapped fields in discover sidebar when reading fields from source.

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

  • Unit or functional tests were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
    - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
    - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
    - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
    - [ ] This was checked for cross-browser compatibility

For maintainers

@majagrubic majagrubic requested review from a team and wylieconlon February 17, 2021 18:21
@majagrubic majagrubic added v7.12.0 Feature:Discover Discover Application release_note:fix release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Feb 17, 2021
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR in comparison to 7.11 and found that it restores the previous behavior. LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 426.5KB 426.5KB +72.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit 94f0bd9 into elastic:master Feb 18, 2021
@majagrubic majagrubic deleted the unmapped_fields_source branch February 18, 2021 08:34
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 18, 2021
* [Discover] Show unmapped fields when reading from source

* Adding a unit test
@timroes timroes added the v8.0.0 label Feb 18, 2021
majagrubic pushed a commit that referenced this pull request Feb 18, 2021
…1805)

* [Discover] Show unmapped fields when reading from source

* Adding a unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover doesn't show unmapped/unknown fields when in _source mode
4 participants