Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Making source filters test run with fields API #91404

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Feb 15, 2021

Summary

Follow-up on:
#89837

Since fields API now supports source filtering, enabling a functional test to verify this behavior

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

For maintainers

@majagrubic majagrubic added v7.12 release_note:skip Skip the PR/issue when compiling release notes Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@majagrubic majagrubic requested review from kertal and a team February 15, 2021 13:50
@majagrubic majagrubic added v7.12.0 and removed v7.12 labels Feb 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test, but Jenkins did. One possible improvement, you could run this test with and without searchFieldsFromSource enabled then both cases would be covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants