Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Search Source] Fix retrieval of unmapped fields; Add field filters (#89837) #91398

Closed
wants to merge 1 commit into from

Conversation

sorenlouv
Copy link
Member

Backports the following commits to 7.x:

…lastic#89837)

* [Search Source] Remove includes when retrieving fields from source

* Removing unusded imports

* Use exclusion filters to retrieve a list of fields

* Exclude _source from fields list

* Fix small check in getting the field list

* Fixing faulty import

* Filter logic

* Adding a unit test for maps use case

* Updating maps unit & functional test

* Add unit test

* Move logic for requesting a field list inside search_source

* Remove unnecessary mock

* Code cleanup as per PR comments

Co-authored-by: Kibana Machine <[email protected]>
@sorenlouv sorenlouv force-pushed the backport/7.x/pr-89837 branch from f027c0e to 3a27e3f Compare February 15, 2021 13:08
@sorenlouv
Copy link
Member Author

Just testing. Closing.

@sorenlouv sorenlouv closed this Feb 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 615 702 +87

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 236.5KB 236.5KB +2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 801.1KB 907.0KB +105.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv deleted the backport/7.x/pr-89837 branch February 16, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants