-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Adds Indicator path config for indicator match rules #91260
Commits on Feb 12, 2021
-
Add new field for overriding threat indicator path
There is no UI for this currently, nor is it used during rule execution.
Configuration menu - View commit details
-
Copy full SHA for 8404f50 - Browse repository at this point
Copy the full SHA 8404f50View commit details -
Adds form field for indicator path parameter
Also adds missing plumbing that was preventing the new field from being persisted to the alert/returned in the response.
Configuration menu - View commit details
-
Copy full SHA for 1bcf451 - Browse repository at this point
Copy the full SHA 1bcf451View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b3956a - Browse repository at this point
Copy the full SHA 0b3956aView commit details -
Add unit test for enriching from a custom indicator path
We always persist to `threat.indicator.*` on the signal, but this allows users to specify where the enrichment fields can be found on the matched indicator document.
Configuration menu - View commit details
-
Copy full SHA for b4749a9 - Browse repository at this point
Copy the full SHA b4749a9View commit details -
Wire up the missing piece of our indicator path config
We were not passing this from the rule itself into the threat matching logic, and so were merely getting the default value. An integration test will fix this. Incoming!
Configuration menu - View commit details
-
Copy full SHA for 6b2d1d7 - Browse repository at this point
Copy the full SHA 6b2d1d7View commit details -
Move indicator path defaulting outside of helper functions
This happens closer to where we pass data from the rule to our helpers, and will prevent errors/bugs due to defaulting logic down the road. It makes tests a little more verbose, but that's okay.
Configuration menu - View commit details
-
Copy full SHA for c33dc3a - Browse repository at this point
Copy the full SHA c33dc3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5004db - Browse repository at this point
Copy the full SHA c5004dbView commit details
Commits on Feb 15, 2021
-
Make threat indicator path a conditional field
Always sending along this field, but only allowing it for threat match rules was implicitly breaking the workflow of otther rule types. By making the field conditional on the rule type, this field only impacts threat match rules. This also fixes some types and tests accordingly.
Configuration menu - View commit details
-
Copy full SHA for 5da3b12 - Browse repository at this point
Copy the full SHA 5da3b12View commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for af0e0f1 - Browse repository at this point
Copy the full SHA af0e0f1View commit details