Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add Create Data Frame Analytics card to Data Visualizer #91011

Merged
merged 5 commits into from
Feb 11, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 10, 2021

Summary

This PR adds Create Data Frame Analytics card to the data visualizer. It also reformats the cards to look consistent.

Screen Shot 2021-02-10 at 11 51 44

Checklist

Delete any items that are not applicable to this PR.

@qn895 qn895 self-assigned this Feb 10, 2021
@qn895 qn895 added the Feature:File and Index Data Viz ML file and index data visualizer label Feb 10, 2021
@qn895 qn895 marked this pull request as ready for review February 10, 2021 23:03
@qn895 qn895 requested a review from a team as a code owner February 10, 2021 23:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on the code. Otherwise LGTM

@@ -57,12 +48,22 @@ export const ActionsPanel: FC<Props> = ({ indexPattern, searchString, searchQuer
setRecognizerResultsCount(recognizerResults.count);
},
};
const showCreateJob =
const mlAvailable = isFullLicense() && checkPermission('canCreateJob') && mlNodesAvailable();
const showCreateAnomalyDetectionJob =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the first three checks below with mlAvailable ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here 97ccf83

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 68.3KB 68.4KB +127.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit 13740f1 into elastic:master Feb 11, 2021
@qn895 qn895 deleted the ml-dfa-card-to-data-visualizer branch February 11, 2021 19:45
qn895 added a commit to qn895/kibana that referenced this pull request Feb 11, 2021
qn895 added a commit that referenced this pull request Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants