Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege #90895

Merged
merged 5 commits into from
Feb 11, 2021
Merged

[Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege #90895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86fc1f6
Adds list SO to Security feature privilege and update tests
spong Feb 10, 2021
9616952
Merge branch 'master' of github.com:elastic/kibana into add-list-so-f…
spong Feb 10, 2021
f455eb0
Adds functional tests for less permissive users not being able to cre…
spong Feb 10, 2021
3e15d7f
Merge branch 'master' into add-list-so-feature-privilege
kibanamachine Feb 11, 2021
d3d1f96
Merge branch 'master' into add-list-so-feature-privilege
kibanamachine Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ion/server/lib/detection_engine/scripts/roles_users/detections_admin/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"siem": ["all"],
"actions": ["read"],
"builtInAlerts": ["all"],
"dev_tools": ["all"],
"savedObjectsManagement": ["all"]
"dev_tools": ["all"]
},
"spaces": ["*"]
}
Expand Down
1 change: 0 additions & 1 deletion ...urity_solution/server/lib/detection_engine/scripts/roles_users/hunter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ This user can CRUD rules and signals. The main difference here is the user has

```json
"builtInAlerts": ["all"],
"savedObjectsManagement": ["all"]
```

privileges whereas the T1 and T2 have "read" privileges which prevents them from creating rules
Expand Down
3 changes: 1 addition & 2 deletions ...rity_solution/server/lib/detection_engine/scripts/roles_users/hunter/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"ml": ["read"],
"siem": ["all"],
"actions": ["read"],
"builtInAlerts": ["all"],
"savedObjectsManagement": ["all"]
"builtInAlerts": ["all"]
},
"spaces": ["*"]
}
Expand Down
3 changes: 1 addition & 2 deletions ...on/server/lib/detection_engine/scripts/roles_users/platform_engineer/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"ml": ["all"],
"siem": ["all"],
"actions": ["all"],
"builtInAlerts": ["all"],
"savedObjectsManagement": ["all"]
"builtInAlerts": ["all"]
},
"spaces": ["*"]
}
Expand Down
3 changes: 1 addition & 2 deletions ...rity_solution/server/lib/detection_engine/scripts/roles_users/reader/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"ml": ["read"],
"siem": ["read"],
"actions": ["read"],
"builtInAlerts": ["read"],
"savedObjectsManagement": ["read"]
"builtInAlerts": ["read"]
},
"spaces": ["*"]
}
Expand Down
3 changes: 1 addition & 2 deletions ...solution/server/lib/detection_engine/scripts/roles_users/rule_author/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"ml": ["read"],
"siem": ["all"],
"actions": ["read"],
"builtInAlerts": ["all"],
"savedObjectsManagement": ["all"]
"builtInAlerts": ["all"]
},
"spaces": ["*"]
}
Expand Down
3 changes: 1 addition & 2 deletions ...solution/server/lib/detection_engine/scripts/roles_users/soc_manager/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"ml": ["read"],
"siem": ["all"],
"actions": ["all"],
"builtInAlerts": ["all"],
"savedObjectsManagement": ["all"]
"builtInAlerts": ["all"]
},
"spaces": ["*"]
}
Expand Down
5 changes: 2 additions & 3 deletions ..._solution/server/lib/detection_engine/scripts/roles_users/t1_analyst/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@
{
"feature": {
"ml": ["read"],
"siem": ["all"],
"siem": ["read"],
"actions": ["read"],
"builtInAlerts": ["read"],
"savedObjectsManagement": ["read"]
"builtInAlerts": ["read"]
},
"spaces": ["*"]
}
Expand Down
5 changes: 2 additions & 3 deletions ..._solution/server/lib/detection_engine/scripts/roles_users/t2_analyst/detections_role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
{
"feature": {
"ml": ["read"],
"siem": ["all"],
"siem": ["read"],
"actions": ["read"],
"builtInAlerts": ["read"],
"savedObjectsManagement": ["read"]
"builtInAlerts": ["read"]
},
"spaces": ["*"]
}
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugins/security_solution/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
'cases-comments',
'cases-configure',
'cases-user-actions',
'exception-list',
'exception-list-agnostic',
...savedObjectTypes,
],
read: ['config'],
Expand All @@ -243,6 +245,8 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
'cases-comments',
'cases-configure',
'cases-user-actions',
'exception-list',
'exception-list-agnostic',
...savedObjectTypes,
],
},
Expand Down
1 change: 0 additions & 1 deletion x-pack/test/detection_engine_api_integration/security_and_spaces/roles_users_utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ interface RoleInterface {
siem: string[];
actions: string[];
builtInAlerts: string[];
savedObjectsManagement: string[];
};
spaces: string[];
}>;
Expand Down
Loading