-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Revamp integration detail page #90887
Conversation
@@ -0,0 +1,238 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a rename from settings_panel.tsx
, not a new file
Pinging @elastic/fleet (Feature:Fleet) |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Looks good! Two minor questions: In the screenshot widget, the number of the current screenshot as well as the overall number are links, but I am not sure what should happen when I click on them: When I install an integration from the Settings view with "Install ... assets", and then refresh the page, the 'Policies' tab correctly appears. Same if I navigate away to "Browse all integrations" and then view the integration page again. I wonder if the 'Policies' tab should appear immediately after the integration has been installed. Same when uninstalling the integration from that page, the 'Policies' tab stays until a refresh, but it should disappear. NOTE: this has probably been the case for a while, and is not an issue introduced with this change, so feel free to ignore for now. Looking at the code now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 🚀
@skh Thanks for the review! Re: screenshot links. This is using the compressed EUI pagination component. Clicking the total number should jump you to the last image, the current page number looks like a link but looking at the doc example I think it's just styled as an indicator of which page you're on. For the Policies tab issues, I filed a separate bug: #90992. You're right that it's existing behavior today too. I took a brief look at what a fix might entail and it has a bit of complexity, so would rather resolve that separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution changes LGTM 👍
Thank you
* Extract integration detail page changes from POC * Remove unneccessary link wrappers * Remove unused import * Fix method name * Fix linting Co-authored-by: Kibana Machine <[email protected]>
Summary
This PR revamps the integration detail > overview page to match with the design work done for top-level Integrations UI app. That project is currently under rescoping, but there was a POC done already that has these changes. We will want to update the overview page regardless of other aspects of that project, so we might as well update now by pulling the relevant work from the POC branch before it diverges too far from main branch.
Design brief: #90047 (comment)
UI changes:
Other code changes:
x-pack/plugins/fleet/public/applications/fleet/sections/epm/screens/detail/
directory so that it has subdirectories for each detail tab (Overview, Policies, Settings, Custom) and a common components directory<Route>
to render the right tab instead of conditionals on thepanel
paramResolves #90933.
Screenshots
Uninstalled integration with screenshots:
Installed integration that also has custom UI extensions: