Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Revamp integration detail page #90887

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Feb 10, 2021

Summary

This PR revamps the integration detail > overview page to match with the design work done for top-level Integrations UI app. That project is currently under rescoping, but there was a POC done already that has these changes. We will want to update the overview page regardless of other aspects of that project, so we might as well update now by pulling the relevant work from the POC branch before it diverges too far from main branch.

Design brief: #90047 (comment)

UI changes:

  • Remove "Read more" and "Collapse" toggles for integration documentation, we will always load the full documentation
  • Screenshots moved to right column in a carousel, they can be clicked to view full screen
  • Details (version, categories, list of assets, etc) moved to below screenshots in right column and re-styled

Other code changes:

  • Restructuring of x-pack/plugins/fleet/public/applications/fleet/sections/epm/screens/detail/ directory so that it has subdirectories for each detail tab (Overview, Policies, Settings, Custom) and a common components directory
  • Explicit route naming of each detail tab so that we can use <Route> to render the right tab instead of conditionals on the panel param

Resolves #90933.

Screenshots

Uninstalled integration with screenshots:

image

Installed integration that also has custom UI extensions:

image

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 labels Feb 10, 2021
@jen-huang jen-huang self-assigned this Feb 10, 2021
@@ -0,0 +1,238 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rename from settings_panel.tsx, not a new file

@jen-huang jen-huang marked this pull request as ready for review February 10, 2021 05:42
@jen-huang jen-huang requested a review from a team as a code owner February 10, 2021 05:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@jen-huang jen-huang requested a review from a team February 10, 2021 05:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 458 461 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 760.1KB 754.3KB -5.8KB
securitySolution 7.5MB 7.5MB -8.0B
total -5.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 365.9KB 366.5KB +521.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@skh
Copy link
Contributor

skh commented Feb 10, 2021

Looks good! Two minor questions:


In the screenshot widget, the number of the current screenshot as well as the overall number are links, but I am not sure what should happen when I click on them:

image


When I install an integration from the Settings view with "Install ... assets", and then refresh the page, the 'Policies' tab correctly appears. Same if I navigate away to "Browse all integrations" and then view the integration page again. I wonder if the 'Policies' tab should appear immediately after the integration has been installed. Same when uninstalling the integration from that page, the 'Policies' tab stays until a refresh, but it should disappear.

NOTE: this has probably been the case for a while, and is not an issue introduced with this change, so feel free to ignore for now.


Looking at the code now.

Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🚀

@jen-huang
Copy link
Contributor Author

@skh Thanks for the review!

Re: screenshot links. This is using the compressed EUI pagination component. Clicking the total number should jump you to the last image, the current page number looks like a link but looking at the doc example I think it's just styled as an indicator of which page you're on.

For the Policies tab issues, I filed a separate bug: #90992. You're right that it's existing behavior today too. I took a brief look at what a fix might entail and it has a bit of complexity, so would rather resolve that separately.

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution changes LGTM 👍

Thank you

@jen-huang jen-huang merged commit c2b41c4 into elastic:master Feb 10, 2021
@jen-huang jen-huang deleted the fix/integration-details branch February 10, 2021 20:03
jen-huang added a commit that referenced this pull request Feb 11, 2021
* Extract integration detail page changes from POC

* Remove unneccessary link wrappers

* Remove unused import

* Fix method name

* Fix linting

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Scroller is given for empty screen under the Endpoint Security Integration tab.
5 participants